Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): fix checklist PR comment #11674

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Oct 7, 2024

Supporting documentation

xrel: #11654 #11666

@lahabana lahabana requested a review from a team as a code owner October 7, 2024 08:22
@lahabana lahabana requested review from bartsmykla and lobkovilya and removed request for a team October 7, 2024 08:22
@lahabana lahabana added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Oct 7, 2024
@lahabana lahabana changed the title ci(github): fix bad quotes on PR comment ci(github): fix checklist PR comment Oct 7, 2024
@@ -1,4 +1,3 @@
name: "PR health"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the title makes debugging just harder:
Uploading image.png…

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lahabana i think your image is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this name you get the filename instead of the name. This makes it a lot easier to figure what action is actually failing

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it? That's so noisy to me. the awful prefix in front of everything and then .yaml. Can't you always jump to Workflow file on the left of the run summary and even see the name at the top of the list of runs for that workflow?

Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
lahabana added a commit to lahabana/kuma that referenced this pull request Oct 7, 2024
It's broken and I don't have time to fix it yet

xrel: kumahq#11654 kumahq#11666 kumahq#11674

Signed-off-by: Charly Molter <[email protected]>
lahabana added a commit that referenced this pull request Oct 7, 2024
It's broken and I don't have time to fix it yet

xrel: #11654 #11666 #11674

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana marked this pull request as draft October 7, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants