Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output failures are not logged #109

Closed
excalq opened this issue Apr 27, 2023 · 0 comments · Fixed by #110
Closed

Output failures are not logged #109

excalq opened this issue Apr 27, 2023 · 0 comments · Fixed by #110
Assignees
@excalq
Labels
enhancement New feature or request

Comments

@excalq
Copy link
Contributor

excalq commented Apr 27, 2023 •
edited
Loading

Output success/failure metrics would be useful. Such as:

logstash_stats_pipeline_plugin_documents_successes{plugin_type='output',plugin="opensearch"}
logstash_stats_pipeline_plugin_documents_non_retryable_failures{plugin_type='output',plugin="opensearch"}
logstash_stats_pipeline_plugin_bulk_requests_with_errors{plugin_type='output',plugin="opensearch"}

Also, ES/OS plugins provide HTTP response codes in the bulk_requests object:
logstash_stats_pipeline_plugin_bulk_requests_responses{plugin_type='output',http_status='NNN'}

Data source in Logstash API:
image
@excalq excalq added the enhancement New feature or request label Apr 27, 2023
@excalq excalq self-assigned this Apr 27, 2023
excalq added a commit to excalq/logstash-exporter that referenced this issue Apr 28, 2023
@excalq
kuskoman#109 Adds output/bulk-request success/error metrics
57d5a3f
excalq added a commit to excalq/logstash-exporter that referenced this issue Apr 28, 2023
@excalq
kuskoman#109 add metric tests
00a5a3a
@excalq excalq mentioned this issue Apr 28, 2023
Merged
kuskoman added a commit that referenced this issue May 6, 2023
@excalq @kuskoman
Add error count metrics (#110)
3f03c69 
* #109 Adds output/bulk-request success/error metrics

* #109 add metric tests

* Simplifies output success/fail metrics by removing omitempty

* Updates snapshots for testing

* Update metric names

---------

Co-authored-by: Jakub Surdej <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@excalq excalq

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error count metrics excalq/logstash-exporter
2 participants
@excalq @kuskoman