-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error count metrics #110
Add error count metrics #110
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 496 513 +17
=========================================
+ Hits 496 513 +17
☔ View full report in Codecov by Sentry. |
@excalq lint seems to fail:
|
I learned something new in Golang: https://www.sohamkamani.com/golang/omitempty/ |
@kuskoman I've updated the structs snapshot to fix Github's checks. This should be ready for review. |
@excalq after merging master to the branch integration test seems to fail, could you re-generate the metrics? |
Resolves #109. Adds metrics, test expected metrics, fixtures, structs, and snapshots.
Adds new metrics as follows:
Note, as I'm pre-populating all counters with 0 (except for bulk HTTP response codes), there is some additional nil checking and looping. Does this merit additional tests?