Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dump generation #1695

Merged
merged 6 commits into from
Jul 7, 2020
Merged

Fix dump generation #1695

merged 6 commits into from
Jul 7, 2020

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Jun 26, 2020

What does this PR do ?

Fix the call to dumpGenerator.dump method

@Aschen Aschen self-assigned this Jun 26, 2020
@Aschen Aschen changed the base branch from master to 2-dev June 26, 2020 04:29
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1695 into 2-dev will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2-dev    #1695      +/-   ##
==========================================
+ Coverage   93.68%   93.70%   +0.01%     
==========================================
  Files         115      115              
  Lines        7224     7224              
==========================================
+ Hits         6768     6769       +1     
+ Misses        456      455       -1     
Impacted Files Coverage Δ
lib/kuzzle/kuzzle.js 96.84% <100.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeee47d...513e589. Read the comment docs.

test/mocks/kuzzle.mock.js Outdated Show resolved Hide resolved
Co-authored-by: Leonardo D'Aubeterre <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.2% 0.2% Duplication

@Leodau Leodau merged commit 9cf758b into 2-dev Jul 7, 2020
@Leodau Leodau deleted the fix-dump branch July 7, 2020 11:25
This was referenced Jul 7, 2020
scottinet added a commit that referenced this pull request Jul 8, 2020
# [2.3.2](https://github.com/kuzzleio/kuzzle/releases/tag/2.3.2) (2020-07-07)


#### Bug fixes

- [ [#1701](#1701) ] Fix: description should not be required for plugin custom errors   ([scottinet](https://github.com/scottinet))
- [ [#1695](#1695) ] Fix dump generation   ([Aschen](https://github.com/Aschen))
- [ [#1698](#1698) ] Fix generic events on search queries   ([scottinet](https://github.com/scottinet))

#### Enhancements

- [ [#1702](#1702) ] Update search indexes only when the "dynamic" setting changes from false to true/strict   ([Aschen](https://github.com/Aschen))
- [ [#1630](#1630) ] Loose coupling: security module   ([scottinet](https://github.com/scottinet))
- [ [#1604](#1604) ] Add request ID in log   ([Aschen](https://github.com/Aschen))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants