Update search indexes only when the "dynamic" setting changes from false to true/strict #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2-dev #1702 +/- ##
=======================================
Coverage 93.53% 93.54%
=======================================
Files 113 114 +1
Lines 7212 7250 +38
=======================================
+ Hits 6746 6782 +36
- Misses 466 468 +2
Continue to review full report at Codecov.
|
scottinet
suggested changes
Jul 7, 2020
Aschen
force-pushed
the
update-search-index-when-dynamic-changes
branch
from
bc966ec
to
8618b1d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
scottinet
approved these changes
Jul 7, 2020
jenow
approved these changes
Jul 7, 2020
scottinet
changed the title
This was referenced Jul 7, 2020
Closed
Closed
Merged
scottinet
added a commit
that referenced
this pull request
Jul 8, 2020
# [2.3.2](https://github.com/kuzzleio/kuzzle/releases/tag/2.3.2) (2020-07-07) #### Bug fixes - [ [#1701](#1701) ] Fix: description should not be required for plugin custom errors ([scottinet](https://github.com/scottinet)) - [ [#1695](#1695) ] Fix dump generation ([Aschen](https://github.com/Aschen)) - [ [#1698](#1698) ] Fix generic events on search queries ([scottinet](https://github.com/scottinet)) #### Enhancements - [ [#1702](#1702) ] Update search indexes only when the "dynamic" setting changes from false to true/strict ([Aschen](https://github.com/Aschen)) - [ [#1630](#1630) ] Loose coupling: security module ([scottinet](https://github.com/scottinet)) - [ [#1604](#1604) ] Add request ID in log ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Force the search index update only if at least one dynamic field value went from
falsetotrue