Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): add newResponse for function SearchAllPages #770

Merged
merged 5 commits into from
May 5, 2022
Merged

fix(api): add newResponse for function SearchAllPages #770

merged 5 commits into from
May 5, 2022

Commits on May 5, 2022

  1. add newResponse for function SearchAllPages 

    This is necessary as using the current response to iterate over pages
corrupts data that are slices, such as the tags within imageInfo. This is beacause
the memory address from the previous response will still contain data from the previous request.
By creating a new response using the nextPage url we get a new spot in memory to put the next
requests data.

Signed-off-by: aircraft-cerier <[email protected]>
    @aircraft-cerier @rmoles
    aircraft-cerier authored and rmoles committed May 5, 2022
    Configuration menu
    Copy the full SHA
    3a6f6f1 View commit details
    Browse the repository at this point in the history

  2. add newResponse for function SearchAllPages 

    This is necessary as using the current response to iterate over pages
corrupts data that are slices, such as the tags within imageInfo. This is beacause
the memory address from the previous response will still contain data from the previous request.
By creating a new response using the nextPage url we get a new spot in memory to put the next
requests data.

Signed-off-by: aircraft-cerier <[email protected]>
    @aircraft-cerier @rmoles
    aircraft-cerier authored and rmoles committed May 5, 2022
    Configuration menu
    Copy the full SHA
    750cd03 View commit details
    Browse the repository at this point in the history

  3. typo in type 

    Signed-off-by: aircraft-cerier <[email protected]>
    @aircraft-cerier @rmoles
    aircraft-cerier authored and rmoles committed May 5, 2022
    Configuration menu
    Copy the full SHA
    def488f View commit details
    Browse the repository at this point in the history

  4. typo in type 

    Signed-off-by: aircraft-cerier <[email protected]>
    @aircraft-cerier @rmoles
    aircraft-cerier authored and rmoles committed May 5, 2022
    Configuration menu
    Copy the full SHA
    b8916bf View commit details
    Browse the repository at this point in the history

  5. fix signing 

    Signed-off-by: aircraft-cerier <[email protected]>
    @aircraft-cerier @rmoles
    aircraft-cerier authored and rmoles committed May 5, 2022
    Configuration menu
    Copy the full SHA
    40030b4 View commit details
    Browse the repository at this point in the history