feat: Add org account mappings to Agentless for AWS #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wl-smith
force-pushed
the
add-org-account-mappings-to-awls
branch
2 times, most recently
from
f208ce5
to
c39e325
Compare
afiune
reviewed
May 8, 2023
examples/resource_lacework_integration_aws_org_agentless_scanning/main.tf
Outdated
Show resolved
Hide resolved
wl-smith
force-pushed
the
add-org-account-mappings-to-awls
branch
3 times, most recently
from
937201d
to
cb40e0d
Compare
wl-smith
changed the title
wl-smith
force-pushed
the
add-org-account-mappings-to-awls
branch
2 times, most recently
from
7f7debc
to
46d407f
Compare
wl-smith
force-pushed
the
add-org-account-mappings-to-awls
branch
from
342f7b4
to
ed75185
Compare
wl-smith
force-pushed
the
add-org-account-mappings-to-awls
branch
from
2505e90
to
ea3bb24
Compare
afiune
changed the title
afiune
reviewed
May 30, 2023
There was a problem hiding this comment.
Maybe we can reuse most of the code at https://github.com/lacework/terraform-provider-lacework/blob/main/lacework/resource_lacework_integration_aws_ct.go#L318-L385?
lacework/resource_lacework_integration_aws_org_agentless_scanning.go
Outdated
Show resolved
Hide resolved
lacework/resource_lacework_integration_aws_org_agentless_scanning.go
Outdated
Show resolved
Hide resolved
|
CI failure is NOT related to this change. |
Merged
afiune
added a commit
to lacework/terraform-aws-agentless-scanning
that referenced
this pull request
Jun 15, 2023
The PR lacework/terraform-provider-lacework#473 introduced a new field named `org_account_mappings` which is only available from version `1.8.0` and above. We made use of this new variable with PR #81 but we forgot to bump the min version, this causes potential issues like #83 where users might be using an older version of the Lacework provider that does not have this new field. The fix is to update the version constraint to `~> 1.8` Note: If you don't know about the pessimistic constraint, please read this doc; https://developer.hashicorp.com/terraform/language/expressions/version-constraints#version-constraint-syntax
afiune
added a commit
to lacework/terraform-aws-agentless-scanning
that referenced
this pull request
Jun 15, 2023
The PR lacework/terraform-provider-lacework#473 introduced a new field named `org_account_mappings` which is only available from version `1.8.0` and above. We made use of this new variable with PR #81 but we forgot to bump the min version, this causes potential issues like #83 where users might be using an older version of the Lacework provider that does not have this new field. The fix is to update the version constraint to `~> 1.8` Note: If you don't know about the pessimistic constraint, please read this doc; https://developer.hashicorp.com/terraform/language/expressions/version-constraints#version-constraint-syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: (https://lacework.atlassian.net/browse/RAIN-54797)
Description:
This is step #2 to provide LW Org support for Terraform integrations for Agentless. Step 1 having been to update go-sdk: lacework/go-sdk#1251.
Additional Info:
The changes made were essentially to add the account mapping file to the awsOrgAgentlessScanningIntegrationSchema in terraform, add helper functions to get & manipulate the account mapping input from the customer.
Tests:
Added a new integration test specifically for AwsSidekickOrg Integrations as well as updated the example terraform and the response object to get the AwsAgentlessOrgScanningResponse, which is a new function in integration.go that uses the LwOrgClient instead of the LwClient.