Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 support added #12

Merged
merged 1 commit into from
Oct 18, 2023
Merged

PHP 8.3 support added #12

merged 1 commit into from
Oct 18, 2023

Conversation

glo71317
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@samsonasik
Copy link
Member

while probably merge-able, I recommend you or magento team (if still used it) to move to composer autoload instead

@froschdesign
Copy link
Member

I recommend you or magento team (if still used it) to move to composer autoload instead

Absolutely! 👍🏻

@froschdesign
Copy link
Member

@samsonasik
Copy link
Member

@froschdesign I just realize that, it seems laminas-loader need to be removed from other laminas components usage, but first, laminas-mvc-skeleton need to apply it first probably:

@froschdesign
Copy link
Member

@samsonasik

it seems laminas-loader need to be removed from other laminas components usage, but first, laminas-mvc-skeleton need to apply it first probably

Right, but it seems to be blocked?!

@samsonasik
Copy link
Member

that seems require drop in laminas-modulemanager first

@glo71317
Copy link
Contributor Author

glo71317 commented Oct 11, 2023

@samsonasik @froschdesign I am Magento Team member. We are working for magento only, We are working to support php8.3 in adobe commerce. So, we are blocked due to laminas dependencies.
Need to merge this PR and also few laminas packages are dependent on laminas-loader. So, Immediately we can not drop from other laminas packages and also we can plan magento side. May be drop of laminas-loader can be plan in future.

@glo71317
Copy link
Contributor Author

@froschdesign Can you please proceed for merging if all looks good to you? Because we are working on updating Magento dependencies so blocked

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glo71317

@Ocramius Ocramius self-assigned this Oct 18, 2023
@Ocramius Ocramius added this to the 2.10.0 milestone Oct 18, 2023
@Ocramius Ocramius merged commit e6fe952 into laminas:2.10.x Oct 18, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants