PHP 8.3 support added #117
Conversation
|
I went over a few of your PRs, @glo71317: as much as I appreciate that Adobe wants PHP 8.3 support, we need builds to be green, in order for a merge to happen 😬 These patches show intent, but are of no help, if they stay red: it's just more work on @laminas/technical-steering-committee |
@Ocramius completely agree :) But there is dependencies on other packages so builds are red, In order to make the build green following green build need to merge If you have any pr comments then feel free leave the comments we will resolve the pr comments asap else proceed for merge above prs to speed up to make green other prs :) |
|
Yes, but the current effect is that I have a huge load of emails, and I'm just playing whack-a-mole with them. That's why I'm saying it isn't helpful 😁 I will go through the list from your comment though 👍 |
|
Meanwhile, all mentioned patches should have associated releases 👍 |
|
For those packages where transitive dependencies are not yet supporting PHP 8.3 and therefore the checks are not passing, you can add {
"ignore_php_platform_requirements": {
"8.3": true
}
}If checks are still failing afterwards, that might be related to transitive dependencies not supporting PHP 8.3. In any case, we have to wait until there are patched versions for those components which lead to failing tests due to the PHP update. |
|
@Ocramius I have updated all associated release for patches and tests are green now. |
| <DeprecatedMethod occurrences="5"> | ||
| <code>$this->returnValue</code> | ||
| </DeprecatedMethod> |
There was a problem hiding this comment.
These deprecations can be fixed in the test with MockObject::willReturn($whatever)
| <DeprecatedMethod occurrences="2"> | ||
| <code>$this->returnValue</code> | ||
| </DeprecatedMethod> | ||
| </file> | ||
| <file src="test/HydratorTestTrait.php"> | ||
| <DeprecatedMethod occurrences="4"> | ||
| <code>$this->returnValue</code> | ||
| </DeprecatedMethod> | ||
| </file> | ||
| <file src="test/NamingStrategy/CompositeNamingStrategyTest.php"> | ||
| <DeprecatedMethod occurrences="4"> | ||
| <code>$this->returnValue</code> | ||
| </DeprecatedMethod> |
There was a problem hiding this comment.
These deprecations can be fixed in the test with MockObject::willReturn($whatever)
| <ArgumentTypeCoercion> | ||
| <code>$pattern</code> | ||
| </ArgumentTypeCoercion> |
There was a problem hiding this comment.
This can be solved by asserting that preg_match receives a non-empty-string
| <ArgumentTypeCoercion> | ||
| <code>$pcreInfo->pattern</code> | ||
| </ArgumentTypeCoercion> |
There was a problem hiding this comment.
This can be solved by asserting that preg_match receives a non-empty-string
|
Handled in #118 |
Description