PHP 8.3 support added #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glo71317
force-pushed
the
php8.3_support
branch
from
83f39f2
to
ba763b9
Compare
|
@froschdesign Can you please review the PR? We are looking for your help to merge this because we are working on Magento Dependencies and support php 8.3 due to laminas dependencies we are blocked so looking forward from your side. Can you please do the needful? |
Ocramius
requested changes
Oct 18, 2023
src/Figlet/Figlet.php
Outdated
| @@ -832,6 +832,10 @@ protected function _smushAmount() | |||
| if (empty($leftChar) || $leftChar === ' ') { | |||
| $amount++; | |||
| } elseif (! empty($rightChar)) { | |||
| /** | |||
| * @psalm-suppress RedundantConditionGivenDocblockType | |||
There was a problem hiding this comment.
We should baseline these, not suppress them
There was a problem hiding this comment.
Made all the suggested changes and pushed the code. Kindly review. Thank you.
src/Table/DecoratorManager.php
Outdated
| /** @var FactoriesConfigurationType */ | ||
| /** | ||
| * @var FactoriesConfigurationType | ||
| * @psalm-suppress NonInvariantDocblockPropertyType |
There was a problem hiding this comment.
This is fixable: doesn't need suppression
src/Table/Table.php
Outdated
| @@ -499,6 +499,7 @@ public function render() | |||
| /** | |||
| * Magic method which returns the rendered table | |||
| * | |||
| * @psalm-suppress MethodSignatureMustProvideReturnType | |||
There was a problem hiding this comment.
This should be baselined, not suppressed
test/MultiByteTest.php
Outdated
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| /** | |||
| * @group Laminas_Text | |||
| * @psalm-suppress DeprecatedMethod | |||
There was a problem hiding this comment.
To be baselined, not suppressed
Ocramius
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description