feat: remap indices on compaction #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to remap IVF/PQ indices. This can be used during compaction to notify the index that row ids have changed. feat: remove tombstones from the IVF remapping process by shrinking the index (#1397) I also simplify the remap tasks a bit by removing some unnecessary traits.
During the commit_compaction step (the last part of compaction, after the fragments have been rewritten) we run an index remapper to remap the indices. This is needed because the row addresses will have changed as part of the compaction. We should only remap indices that had rows in affected fragments. I also removed the "rewrite operation" from the python bindings. This was already a fairly complicated operation and adding rewritten indices to it would make it even more complicated. I don't think users are going to be orchestrating compaction themselves anytime soon (and we can add it back in if needed). Furthermore, the plan compaction capability and serialization of compaction tasks is a much better solution for anyone that wants to orchestrate the compaction process. --------- Co-authored-by: Will Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after compaction runs, any fragments that were covered by an index, and compacted, will no longer be covered by that index.
This PR fixes that. During compaction we calculate the input and output row ids and then rewrite existing indices so that they cover the newly compacted fragments.
Closes #1378