Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinecone[patch]: Update @pinecone/pinecone-database version to resolve type errors #7167

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

nick-w-nick
Copy link
Contributor

Due to a recent @pinecone/pinecone-database release (v4.0.0), there is a type collision between @langchain/pinecone and @pinecone/pinecone-database, since @langchain/pinecone still uses v3.0.0.

Here is the issue in the pinecone-ts-client repository which mentions this bug: pinecone-io/pinecone-ts-client#309

Updating the @langchain/pinecone module to use the v4.0.0 version of @pinecone/pinecone-database fixes the issue.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 9, 2024 7:31pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 9, 2024 7:31pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Nov 6, 2024
@jacoblee93
Copy link
Collaborator

jacoblee93 commented Nov 7, 2024

Thanks for this!

If this isn't breaking - can we make this ^3.0.0 || ^4.0.0?

@nick-w-nick
Copy link
Contributor Author

@jacoblee93 That's a great idea! Just made the update, let me know if that works for you.

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants