Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pinecone): Add support for Pinecone /embed endpoint #7203

Merged
merged 17 commits into from
Nov 17, 2024
Merged

feat(pinecone): Add support for Pinecone /embed endpoint #7203

merged 17 commits into from
Nov 17, 2024

Conversation

aulorbe
Copy link
Contributor

@aulorbe aulorbe commented Nov 14, 2024 •
edited
Loading

This PR gives users the ability to generate dense vector embeddings via Pinecone's Inference API.

@Audrey_Sage_

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 17, 2024 6:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 17, 2024 6:58am

@jacoblee93
Copy link
Collaborator

jacoblee93 commented Nov 14, 2024 •
edited
Loading

Hey @aulorbe just FYI a community member merged a PR updating the required Pinecone version to be more permissive: #7167

@aulorbe
Copy link
Contributor Author

aulorbe commented Nov 14, 2024

Hey @aulorbe just FYI a community member merged a PR updating the required Pinecone version to be more permissive: #7167

Ah sick, thanks!

This PR (now) primarily introduces the embed endpoint. I'll update the desc when it's ready for review!

@aulorbe aulorbe changed the title Upgrade Pinecone integration Upgrade Pinecone version + add support for /embed endpoint Nov 15, 2024
@aulorbe aulorbe changed the title Upgrade Pinecone version + add support for /embed endpoint Add support for Pinecone /embed endpoint Nov 15, 2024
@aulorbe aulorbe marked this pull request as ready for review November 15, 2024 18:25
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Nov 15, 2024
@jacoblee93 jacoblee93 changed the title Add support for Pinecone /embed endpoint feat(pinecone): Add support for Pinecone /embed endpoint Nov 17, 2024
jacoblee93
jacoblee93 approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, thank you!

I can add a quick docs page

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Nov 17, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 17, 2024
@jacoblee93 jacoblee93 merged commit 762ed46 into langchain-ai:main Nov 17, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aulorbe @jacoblee93