[5.0] File upload is broken when submitting a form without selecting a file #6189

Marwelln · 2014-10-22T14:09:23Z

After the recent changes (I did composer update a couple of minutes ago) you can't submit a form if you have enctype="multipart/form-data" and input[type="file"] and leaves the input field empty (no file selected).

Link to error message.

Fatal error: Uncaught exception 'InvalidArgumentException' with message 'An uploaded file must be an array or an instance of UploadedFile.' in /var/www/foobar/public/liferaft/file-upload-fails/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/FileBag.php on line 59

Reproduce

1.

composer create-project laravel/laravel . dev-develop

2.

php artisan clear-compiled

3.

Set debug to true in config/app.php.

4.

Open up app/Providers/RouteServiceProvider.php and change the map method to this:

$router->group(['namespace' => 'App\Http\Controllers'], function() use ($router) {
    $router->get('/', 'HomeController@index');
    $router->put('/', 'HomeController@put');
});

5.

Add the following code to app/Http/HomeController.php:

public function put() {
    dd(\Input::all());
}

6.

Change resources/views/hello.php to this:

<!doctype html>
<html lang="en">
<body>
    <form method='post' enctype='multipart/form-data'>
        <input type='hidden' name='_method' value='put' />
        <input type='hidden' name='_token' value='<?= csrf_token(); ?>' />

        <input type='file' name='image' />
        <button>Send</button>
    </form>
</body>
</html>

If you try to submit the form without selecting a file you will get Uncaught exception 'InvalidArgumentException' with message 'An uploaded file must be an array or an instance of UploadedFile.', but if you select an image, you will get an array from Input::all().

Bad (temporary) solution

A solution is to remove an file arrays with a null value before using the SymfonyRequest::dublicate method.

Change the content of the createFromBase method from

if ($request instanceof static) return $request;

return (new static)->duplicate(

    $request->query->all(), $request->request->all(), $request->attributes->all(),

    $request->cookies->all(), $request->files->all(), $request->server->all()
);

to

if ($request instanceof static) return $request;

$files = [];
foreach ($request->files->all() as $index => $file) {
    if (null !== $file) $files[$index] = $file;
}

return (new static)->duplicate(

    $request->query->all(), $request->request->all(), $request->attributes->all(),

    $request->cookies->all(), $files, $request->server->all()
);

You can now submit the form without selecting a file.

The text was updated successfully, but these errors were encountered:

youanden · 2014-10-22T21:49:56Z

Update - check out @mantasradzevicius post of @lucasmichot 's fix below. It's more holistic and isn't based on javascript or editing core files.

+1

I've been having trouble with laravel-stapler after manually migrating and setting it up. Same result if using a multipart form type.

My solution is hilarious but doesn't require editing core files if you're okay with alienating non-js users:

$(document).ready ->
  $('.profile-form').on 'submit', (e) ->
    $photoInput = $('.profile-photo-input input')
    $photoInput.remove() if $photoInput.val() == ""
    return true

Essentially, I remove the input if the value hasn't been set to anything. Super hacky but it might fit for someone in the interim.

mikedugan · 2014-10-23T03:23:21Z

+1

jeffberry · 2014-10-26T01:22:24Z

+1

Hoping for a fix soon.

etcinit · 2014-10-27T20:45:42Z

I was about to create an issue for this too. I wrote a test case for it:

In HttpRequestTest.php:

 public function testInputWithEmptyFilename()
    {
        $invalidFiles = [
            'file' => [
                'name' => null,
                'type' => null,
                'tmp_name' => null,
                'error' => 4,
                'size' => 0
            ]
        ];

        $baseRequest = \Symfony\Component\HttpFoundation\Request::create('/?boom=breeze', 'GET', array('foo' => array('bar' => 'baz')), array(), $invalidFiles);

        $request = Request::createFromBase($baseRequest);
    }

leothelocust · 2014-10-30T20:41:47Z

+1

jmfleming · 2014-10-31T13:15:19Z

1

MathieuDoyon · 2014-11-04T12:35:52Z

+1

mouhsinelonly · 2014-11-04T13:15:18Z

+1

davidnknight · 2014-11-06T12:03:33Z

+1

wlkns · 2014-11-06T12:04:05Z

+1

alexandre-leites · 2014-11-07T12:12:25Z

+1

jufy · 2014-11-10T08:37:52Z

+1

alexleonard · 2014-11-10T16:29:52Z

+1

ingria · 2014-11-11T00:54:12Z

+1

alexleonard · 2014-11-11T08:53:02Z

Thanks @youanden for the temporary JS fix. Works a treat.

youanden · 2014-11-11T17:01:50Z

@alexleonard glad I could be of service.

colinyoung87 · 2014-11-12T11:49:50Z

@youanden I used your fix, did the trick until a fix came out, thanks!

I've rewritten it a little with jquery to work across all file forms:

$('form[enctype="multipart/form-data"]').on('submit', function(e){
    $(this).find('input[type=file]').each(function(){
        var file = $(this);
        if (file.val() == "") file.remove();
    });
    return true;
});

lucidlemon · 2014-11-12T12:24:28Z

+1 and +1 for marking it as important

gregoryduckworth · 2014-11-13T10:22:42Z

+1

mn7z · 2014-11-13T21:13:54Z

As a temp solution how to apply this fix:

Make a App\Http\Request class which extends Illuminate\Http\Request (example below)
Apply the fix either in this issue or overriding duplicate method #6256.

Example

namespace App\Http;

use Illuminate\Http\Request as LaravelRequest;

class Request extends LaravelRequest
{

    /**
     * {@inheritdoc}
     */
    public function duplicate(
        array $query = null,
        array $request = null,
        array $attributes = null,
        array $cookies = null,
        array $files = null,
        array $server = null
    ) {
        $files = array_filter((array)$files);

        return parent::duplicate(
            $query, 
            $request, 
            $attributes, 
            $cookies, 
            $files, 
            $server
        );
    }
}

modify your public/index.php to capture requests with your new class:

$response = $kernel->handle(
    $request = App\Http\Request::capture()
);
$response->send();

When a permanent fix is released revert public/index.php and remove your Request class.

Does this work: yes
SideEffects: not known

markvdputten · 2014-11-13T23:46:32Z

@colinyoung87 your temproary jQuery solution works perfect, thanks for that!

youanden · 2014-11-14T00:59:12Z

@mantasradzevicius Thanks. I can confirm this worked after changing the namespace accordingly.

gorkhali125 · 2014-11-14T16:31:55Z

@colinyoung87 Thanks for the solution. This worked perfectly.

jonathanpmartins · 2014-11-15T02:06:10Z

Perhaps it can be a Symfony problem. what do you think ?

Fatal error: Uncaught exception 'InvalidArgumentException' with message 'An uploaded file must be an array or an instance of UploadedFile.' in /var/www/html/.../vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/FileBag.php:59 Stack trace: #0 /var/www/html/.../vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/FileBag.php(73): Symfony\Component\HttpFoundation\FileBag->set('image', NULL) #1 /var/www/html/.../vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/FileBag.php(48): Symfony\Component\HttpFoundation\FileBag->add(Array) #2 /var/www/html/.../vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/FileBag.php(37): Symfony\Component\HttpFoundation\FileBag->replace(Array) #3 /var/www/html/.../vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/Request.php(448): Symfony\Component\HttpFoundation\FileBag->__construct(Array) #4 /var/www/html/.../vendor/laravel/framework/src/Illuminate/Http/Reque in /var/www/html/.../vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/FileBag.php on line 59

FileBag->set('image', NULL), receaves NULL, and that is what is dispatching a throw!

...in Symfony on the FileBag.php file, convertFileInformation method returns NULL if no files was selected on the upload.

...without selecting a file in Laravel 5! My tests revealed that with this tweek the problem described at this issue are resolved: laravel/framework#6189 ...in Symfony on the FileBag.php file, convertFileInformation() method returns NULL if no files was selected on the upload. In this case "FileBag->set('image', NULL)" receives NULL, and that is what is dispatching a throw! I don't make unit tests, but this will no more break my code flow. I'm not sure if this is the real deal! If someone could look deeper into the problem, I appreciated! | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT | Doc PR |

sfunaro · 2014-11-16T03:48:30Z

+1
@colinyoung87 temporary solution works perfectly!

pomirleanu · 2015-06-04T06:21:23Z

+1

FranciscoCaldeira · 2020-12-07T11:34:30Z

I have this problem using the multipartGraphQL() when testing the upload of a file! +1

etcinit mentioned this issue Oct 28, 2014

[5.0] Fix Broken File Upload When Submitting A Form Without Selecting A File #6256

Merged

This was referenced Nov 15, 2014

File upload is broken in Laravel 5 when submitting a form without... symfony/symfony#12483

Closed

File upload is broken when submitting a form... symfony/symfony#12485

Closed

jonathanpmartins mentioned this issue Nov 15, 2014

File upload is broken when submitting a form symfony/symfony#12486

Closed

This was referenced Nov 16, 2014

File upload is broken when submitting a form without selecting a file. illuminate/http#14

Closed

[5.0] File upload is broken when submitting a form without selecting a file. #6423

Closed

taylorotwell closed this as completed Nov 20, 2014

Itachicz11 mentioned this issue Nov 27, 2014

Can't upload image mrakodol/Laravel-5-Bootstrap-3-Starter-Site#13

Closed

themsaid mentioned this issue Sep 2, 2016

[5.3] fix multifile uploads when empty #15250

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.0] File upload is broken when submitting a form without selecting a file #6189

[5.0] File upload is broken when submitting a form without selecting a file #6189

Marwelln commented Oct 22, 2014

youanden commented Oct 22, 2014

mikedugan commented Oct 23, 2014

jeffberry commented Oct 26, 2014

etcinit commented Oct 27, 2014

leothelocust commented Oct 30, 2014

jmfleming commented Oct 31, 2014

MathieuDoyon commented Nov 4, 2014

mouhsinelonly commented Nov 4, 2014

davidnknight commented Nov 6, 2014

wlkns commented Nov 6, 2014

alexandre-leites commented Nov 7, 2014

jufy commented Nov 10, 2014

alexleonard commented Nov 10, 2014

ingria commented Nov 11, 2014

alexleonard commented Nov 11, 2014

youanden commented Nov 11, 2014

colinyoung87 commented Nov 12, 2014

lucidlemon commented Nov 12, 2014

gregoryduckworth commented Nov 13, 2014

mn7z commented Nov 13, 2014

markvdputten commented Nov 13, 2014

youanden commented Nov 14, 2014

gorkhali125 commented Nov 14, 2014

jonathanpmartins commented Nov 15, 2014

sfunaro commented Nov 16, 2014

pomirleanu commented Jun 4, 2015

FranciscoCaldeira commented Dec 7, 2020

[5.0] File upload is broken when submitting a form without selecting a file #6189

[5.0] File upload is broken when submitting a form without selecting a file #6189

Comments

Marwelln commented Oct 22, 2014

Reproduce

Bad (temporary) solution

youanden commented Oct 22, 2014

mikedugan commented Oct 23, 2014

jeffberry commented Oct 26, 2014

etcinit commented Oct 27, 2014

leothelocust commented Oct 30, 2014

jmfleming commented Oct 31, 2014

MathieuDoyon commented Nov 4, 2014

mouhsinelonly commented Nov 4, 2014

davidnknight commented Nov 6, 2014

wlkns commented Nov 6, 2014

alexandre-leites commented Nov 7, 2014

jufy commented Nov 10, 2014

alexleonard commented Nov 10, 2014

ingria commented Nov 11, 2014

alexleonard commented Nov 11, 2014

youanden commented Nov 11, 2014

colinyoung87 commented Nov 12, 2014

lucidlemon commented Nov 12, 2014

gregoryduckworth commented Nov 13, 2014

mn7z commented Nov 13, 2014

markvdputten commented Nov 13, 2014

youanden commented Nov 14, 2014

gorkhali125 commented Nov 14, 2014

jonathanpmartins commented Nov 15, 2014

sfunaro commented Nov 16, 2014

pomirleanu commented Jun 4, 2015

FranciscoCaldeira commented Dec 7, 2020