[5.0] Fix Broken File Upload When Submitting A Form Without Selecting A File #6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcinit
changed the title
etcinit
changed the title
| @@ -608,6 +608,28 @@ public static function createFromBase(SymfonyRequest $request) | |||
| } | |||
|
|
|||
| /** | |||
| * Clones a request and overrides some of its parameters. | |||
| * | |||
| * @param array $query | |||
There was a problem hiding this comment.
Please format this docblock correctly.
| @@ -608,6 +608,28 @@ public static function createFromBase(SymfonyRequest $request) | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Why not just ?
/**
* {@inheritdoc}
*/
public function duplicate(array $query = null, array $request = null, array $attributes = null, array $cookies = null, array $files = null, array $server = null)
{
$files = array_filter((array) $files);
return parent::duplicate($query, $request, $attributes, $cookies, $files, $server);
}
etcinit
changed the title
taylorotwell
added a commit
that referenced
this pull request
Nov 20, 2014
[5.0] Fix Broken File Upload When Submitting A Form Without Selecting A File
|
Thank you @Eduard44 and @taylorotwell This bug has drives me crazy! eheheheh |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at fixing (my first PR) the issue:
[5.0] File upload is broken when submitting a form without selecting a file #6189
Right now I'm overriding Symfony's Request::duplicate function so that it can handle empty file form inputs. Another solution is included in the issue (#6189), which modifies the createFromBase function. Both filter the input array to remove any files that are null.