Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Updating AbstractPaginator::appends to handle null #26326

Merged
merged 2 commits into from
Oct 31, 2018
Merged

[5.7] Updating AbstractPaginator::appends to handle null #26326

merged 2 commits into from
Oct 31, 2018

Conversation

pfuhrmann
Copy link
Contributor

This method is most commonly used with $request->query() which recently changed docblock [1] also to return null. Same as original commit, this is to make PHPStan happy.

$events = $query->paginate($perPage);
$events->appends($request->query());

[1] #25954

@pfuhrmann
[5.7] Updating AbstractPaginator::appends to handle null
49ee0f4 
This method is most commonly used with `$request->query()` which recently changed docblock [1] also to return `null`. Same as original commit, this is to make PHPStan happy.

```
$events = $query->paginate($perPage);
$events->appends($request->query());
```

[1] #25954
@pfuhrmann
Removing whitespace
cf5e0c0
@taylorotwell taylorotwell merged commit 0060d98 into laravel:5.7 Oct 31, 2018
@pfuhrmann pfuhrmann deleted the patch-1 branch October 31, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfuhrmann @taylorotwell