Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Updating AbstractPaginator::appends to handle null #26326

Merged
merged 2 commits into from
Oct 31, 2018
Merged

[5.7] Updating AbstractPaginator::appends to handle null #26326

merged 2 commits into from
Oct 31, 2018

Commits on Oct 31, 2018

  1. [5.7] Updating AbstractPaginator::appends to handle null 

    This method is most commonly used with `$request->query()` which recently changed docblock [1] also to return `null`. Same as original commit, this is to make PHPStan happy.

```
$events = $query->paginate($perPage);
$events->appends($request->query());
```

[1] #25954
    @pfuhrmann
    pfuhrmann authored Oct 31, 2018
    Configuration menu
    Copy the full SHA
    49ee0f4 View commit details
    Browse the repository at this point in the history

  2. Removing whitespace

    @pfuhrmann
    pfuhrmann authored Oct 31, 2018
    Configuration menu
    Copy the full SHA
    cf5e0c0 View commit details
    Browse the repository at this point in the history