Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade scala to 2.13.1 #148

Merged
merged 26 commits into from
Nov 20, 2019
Merged

upgrade scala to 2.13.1 #148

merged 26 commits into from
Nov 20, 2019

Conversation

sirocchj
Copy link
Member

No description provided.

@sirocchj
Copy link
Member Author

😞 typelevel/kind-projector#15

@sirocchj
Copy link
Member Author

depends on typelevel/kind-projector#119

barambani
barambani previously approved these changes Oct 3, 2019
View reviewed changes
@sirocchj
Copy link
Member Author

sirocchj commented Oct 3, 2019

😢 scoverage/sbt-scoverage#295

@sirocchj
Merge branch 'master' into 2.13.1
af19258
@sirocchj
Update sbt-scoverage to 1.6.1
a12c034 
This relies on latest (as of today) scalac-scoverage-plugin (1.4.1), which should be compatible with scalac 2.13.1
@codecov-io
Copy link

codecov-io commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   61.13%   61.13%           
=======================================
  Files          36       36           
  Lines        1194     1194           
  Branches        7        8    +1     
=======================================
  Hits          730      730           
  Misses        464      464
Impacted Files Coverage Δ
...s2/src/main/scala/laserdisc/fs2/RedisChannel.scala 73.68% <0%> (-5.27%) ⬇️
core/src/main/scala/laserdisc/protocol/KeyP.scala 92.68% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f7eae...a12c034. Read the comment docs.

@sirocchj
Copy link
Member Author

Looks like this is finally ready to be merged

@sirocchj sirocchj mentioned this pull request Nov 20, 2019
Closed
barambani
barambani approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sirocchj sirocchj merged commit c5200a6 into laserdisc-io:master Nov 20, 2019
@sirocchj sirocchj deleted the 2.13.1 branch November 20, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barambani barambani barambani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirocchj @codecov-io @barambani