Build failure with Scala 2.13.1 #295

plokhotnyuk · 2019-09-18T11:15:29Z

https://travis-ci.org/plokhotnyuk/expression-evaluator/jobs/586472890

error] ## Exception when compiling 1 sources to /Users/travis/build/plokhotnyuk/expression-evaluator/target/scala-2.13/classes
[error] java.lang.NoSuchMethodError: scala.tools.nsc.Global.reporter()Lscala/tools/nsc/reporters/Reporter;
[error] scoverage.ScoverageInstrumentationComponent$$anon$1.run(plugin.scala:119)
[error] scala.tools.nsc.Global$Run.compileUnitsInternal(Global.scala:1506)
[error] scala.tools.nsc.Global$Run.compileUnits(Global.scala:1490)
[error] scala.tools.nsc.Global$Run.compileSources(Global.scala:1482)
...

https://travis-ci.org/plokhotnyuk/jsoniter-scala/jobs/586468216

[error] ## Exception when compiling 4 sources to /Users/travis/build/plokhotnyuk/jsoniter-scala/jsoniter-scala-core/target/scala-2.13/classes
[error] java.lang.NoSuchMethodError: scala.tools.nsc.Global.reporter()Lscala/tools/nsc/reporters/Reporter;
[error] scoverage.ScoverageInstrumentationComponent$$anon$1.run(plugin.scala:119)
[error] scala.tools.nsc.Global$Run.compileUnitsInternal(Global.scala:1506)
[error] scala.tools.nsc.Global$Run.compileUnits(Global.scala:1490)
[error] scala.tools.nsc.Global$Run.compileSources(Global.scala:1482)

The text was updated successfully, but these errors were encountered:

ILLKO · 2019-09-18T17:05:06Z

Needs scalac-scoverage-plugin with this pull request merged scoverage/scalac-scoverage-plugin#279

gslowikowski · 2019-09-19T21:06:19Z

This issue and scoverage/scalac-scoverage-plugin#279 are two different issues.

That one is with plugin test code. This one causes errors in runtime. The source of these two problems is the same - Scala compiler 2.13.1 is not backward compatible with 2.13.0. Scoverage plugin version compiled with Scala 2.13.0 does not work with Scala 2.13.1.

I don't know if this incompatibility is accidental and should be considered a bug or on purpose and what will next version of compiler (Global class) look like. Will they be compatible with version 2.13.0 or 2.13.1 or maybe not compatible with any of them.

lrytz · 2019-09-20T08:24:02Z

scoverage/scalac-scoverage-plugin#279 allows compiling the plugin against 2.13.1 (and it remains compileable with older Scala versions).

The runtime failure is because the scala-compiler.jar of 2.13.1 is not binary compatible with the scala-compiler.jar of 2.13.0. This is not a bug, we only guarantee binary compatibility for the library. This means that compiler plugins have to be fully cross-versioned.

Concretely, scalac-scoverage-plugin_2.13:1.4.1 should not exist, instead there should be scalac-scoverage-plugin_2.13.0 and scalac-scoverage-plugin_2.13.1.

Note that this is true for all compiler plugins (see typelevel/kind-projector#15 for example).

For reference, the changes to wartremover that were done by @xuwei-k to support full cross-versioning: wartremover/wartremover@5c59c86...acc56b8

Necessary until sbt-scoverage [gets fixed](scoverage/sbt-scoverage#295)

Christewart · 2019-09-23T11:12:23Z

Just a 👍 , i'm encourtering this failure when attempting to upgrade bitcoin-s to 2.13.1 https://travis-ci.org/bitcoin-s/bitcoin-s/jobs/588220140#L352

Disable coverage until sbt-scoverage is fixed: scoverage/sbt-scoverage#295 Signed-off-by: 35V LG84 <[email protected]>

Beware of 2.13.1 issue regarding scoverage/sbt-scoverage#295

…coverage/sbt-scoverage#295)

regis-leray · 2019-10-09T01:23:57Z

I have the same issue with scala 2.13.1 and scoverage 1.6.0

openjdk 11.0.4 2019-07-16
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)

[error] java.lang.NoSuchMethodError: 'scala.tools.nsc.reporters.Reporter scala.tools.nsc.Global.reporter()'
[error] scoverage.ScoverageInstrumentationComponent$$anon$1.run(plugin.scala:119)
[error] scala.tools.nsc.Global$Run.compileUnitsInternal(Global.scala:1506)
[error] scala.tools.nsc.Global$Run.compileUnits(Global.scala:1490)
[error] scala.tools.nsc.Global$Run.compileSources(Global.scala:1482)
[error] scala.tools.nsc.Global$Run.compile(Global.scala:1614)
[error] xsbt.CachedCompiler0.run(CompilerInterface.scala:153)
[error] xsbt.CachedCompiler0.run(CompilerInterface.scala:125)
[error] xsbt.CompilerInterface.run(CompilerInterface.scala:39)
[error] java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[error] java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[error] java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[error] java.base/java.lang.reflect.Method.invoke(Method.java:566)

nrinaudo · 2019-10-09T12:50:40Z

I'm also struggling with this issue. If there anything I can do to help getting it resolved?

leonardehrenfried · 2019-10-09T13:22:24Z

I'm not a maintainer but I would guess that if you want to help, you can open a PR that adds full cross-compilation down to the minor version number, as suggested here: #295 (comment)

Basically, this plugin is only cross-compiled for scala 2.13 when it actually needs to be compiled for 2.13.0 and 2.13.1.

Usually this isn't a problem but there appears to be an API change between 2.13.0 and 2.13.1.

* Enable scoverage in 2.13 build Beware of 2.13.1 issue regarding scoverage/sbt-scoverage#295 * Enable apidoc generation for 2.13 * travis: Enable codecoverage for jvm build * Add flag to codecov to differentiate scala versions * Remove sbt keys that do nothing

nrinaudo · 2019-10-14T19:35:00Z

There's another, quicker solution: the one that @olafurpg asked me to put together for mdoc in scalameta/mdoc#196.

Instead of changing the publication mechanism and publishing artifacts for every single version of Scala, keep publishing global ones for 2.11, 2.12 and 2.13, but only make them compatible with the latest Scala version.

For example, if we were to do that to scoverage, the next version would only be tested against 2.11.12, 2.12.10 and 2.13.1.

With the current state of Scala, that would mean:

compatible with 2.11.x for all x
compatible with 2.12.x for all x
compatible with 2.13.1, but not 2.13.0

If the reporter API stays stable from now on, problem sorted. If it doesn't, "just" fix the breakage and release a non-backwards compatible build for the latest versions.

I can absolutely have a go at that if you feel this would be an acceptable solution.

leonardehrenfried · 2019-10-14T19:44:10Z

Speaking as a user, this is a totally acceptable solution.

nrinaudo · 2019-10-15T20:09:56Z

I have a working proof of concept - it's really very little work.

Replace 2.13.0 by 2.13.1 in scalac-scoverage-plugin's build file, and publish locally (+publishLocal).
This should publish version 1.4.1-SNAPSHOT.

Load up whatever project you have that uses scoverage and 2.13.1, and set the appropriate property:

set every coverageScalacPluginVersion := "1.4.1-SNAPSHOT"

Done. You now have working code coverage.

The clean thing to do would be to publish scalac-scoverage-plugin 1.4.1, then update sbt-scoverage so that it defaults to 1.4.1 and not 1.4.0, and publish that. You're done. It's two 1-line-diffs, with the caveat that you've lost support for 2.13.0.

Happy to submit the corresponding PRs, but I'd love to get approval from a project maintainer first that this is the way they want to go.

nrinaudo · 2019-10-16T19:43:54Z

PRs submitted:

Do let me know if there's anything else I can do to push this forward!

This project now compiles with Scala 2.13 by default, while still cross-compiling to Scala 2.12 & 2.11. Although Scala 2.13.1 has been released, this change sticks with 2.13.0, as `scoverage` has not yet released an update compatible with 2.13.1: scoverage/sbt-scoverage#295 scoverage/scalac-scoverage-plugin#283 scoverage/sbt-scoverage#299 Migration issues addressed with the update to Scala 2.13: ### Underscore (`_`) is no longer a valid identifer for `val`s Using underscore like this is no longer allowed... ``` implicit val _ = ... ``` ...we have to give the `val` a valid name (even if it's just `v`): ``` implicit val v = ... ``` See also: * scala/bug#10384 * scala/bug#7691 * scala/scala#6218 ### `Map.mapValues()` now returns a `MapView` rather than a `Map` We usually want a `Map`, so we can just add in a `.toMap` to the end of the expression - it's harmless in Scala 2.12, and allows the code to compile in Scala 2.13. `Map.mapValues()` itself is deprecated in Scala 2.13, but using the new recommended alternative doesn't work in Scala 2.12. https://docs.scala-lang.org/overviews/core/collections-migration-213.html#what-are-the-breaking-changes See also: * scala/bug#10919 * scala/scala#7014 ### `.to` can no longer infer what resulting collection type you want This is all part of `CanBuildFrom` going away in Scala 2.13: https://www.scala-lang.org/blog/2018/06/13/scala-213-collections.html#life-without-canbuildfrom

scoverage is broken on 2.13.1 scoverage/sbt-scoverage#295

polomarcus · 2020-04-28T13:11:28Z

Just met this error, and finding this thread solved is beautiful

Merci @nrinaudo et @D-Roch 🏆

This reverts commit 5e606eb.

asavelyev01 · 2021-03-11T11:41:28Z

Just met this error with Scala 2.12.13. Does it need a different fix?

eugeniyk · 2021-03-19T02:21:31Z

@asavelyev01 duplicate of #319

milessabin mentioned this issue Sep 18, 2019

Add support for type annotations (issue #922) milessabin/shapeless#925

Merged

pjfanning mentioned this issue Sep 18, 2019

fix issue with compiling for scala 2.13.1 scoverage/scalac-scoverage-plugin#280

Closed

gslowikowski mentioned this issue Sep 19, 2019

compatibility with Scala 2.13.1 scoverage/scalac-scoverage-plugin#279

Closed

JanBessai added a commit to combinators/templating that referenced this issue Sep 20, 2019

Restrict coverage generation to Scala 2.12.10

c0589fc

Necessary until sbt-scoverage [gets fixed](scoverage/sbt-scoverage#295)

JanBessai added a commit to combinators/templating that referenced this issue Sep 20, 2019

Restrict coverage generation to Scala 2.12.10

38c5110

Necessary until sbt-scoverage [gets fixed](scoverage/sbt-scoverage#295)

JanBessai added a commit to combinators/templating that referenced this issue Sep 20, 2019

Restrict coverage generation to Scala 2.12.10

78aa258

Necessary until sbt-scoverage [gets fixed](scoverage/sbt-scoverage#295)

JanBessai added a commit to combinators/templating that referenced this issue Sep 20, 2019

Restrict coverage generation to Scala 2.12.10

b4805b9

Necessary until sbt-scoverage [gets fixed](scoverage/sbt-scoverage#295)

JanBessai added a commit to combinators/templating that referenced this issue Sep 20, 2019

Restrict coverage generation to Scala 2.12.10

1369875

Necessary until sbt-scoverage [gets fixed](scoverage/sbt-scoverage#295)

yanns mentioned this issue Sep 27, 2019

update scala versions leanovate/play-mockws#74

Closed

Zukkari mentioned this issue Sep 27, 2019

Configure CodeCov for the project Zukkari/sonar-java-academic-plugin#2

Closed

jcazevedo mentioned this issue Sep 28, 2019

Make some improvements to the build definition pureconfig/pureconfig#601

Merged

35VLG84 added a commit to e257-fi/dirsuite that referenced this issue Sep 28, 2019

ci/cd: update images, add disabled codecov target

58a3e3b

Disable coverage until sbt-scoverage is fixed: scoverage/sbt-scoverage#295 Signed-off-by: 35V LG84 <[email protected]>

mkroli added a commit to mkroli/dns4s that referenced this issue Oct 1, 2019

use scala 2.13.0 due to scoverage/sbt-scoverage#295

c922b47

DieBauer added a commit to DieBauer/cats that referenced this issue Oct 2, 2019

Enable scoverage in 2.13 build

887dc38

Beware of 2.13.1 issue regarding scoverage/sbt-scoverage#295

DieBauer mentioned this issue Oct 2, 2019

Enable coverage and docs typelevel/cats#3096

Merged

sirocchj mentioned this issue Oct 3, 2019

upgrade scala to 2.13.1 laserdisc-io/laserdisc#148

Merged

barambani mentioned this issue Oct 4, 2019

Scala 2.13.1 barambani/http4s-poc-api#132

Merged

pwliwanow mentioned this issue Oct 4, 2019

Re-enable test coverage once sbt-scoverage supports Scala 2.13.1 pwliwanow/foundationdb4s#51

Closed

larsrh mentioned this issue Oct 4, 2019

dependency bumps typelevel/cats-mtl#159

Merged

exoego mentioned this issue Oct 5, 2019

"Bad interaction" with scoverage scala-js/scala-js#3803

Closed

kwark pushed a commit to kwark/slick-refined that referenced this issue Oct 7, 2019

back to scala 2.13.0 => waiting for sbt-scoverage to support 2.13.1 (s…

397f7c2

…coverage/sbt-scoverage#295)

taig mentioned this issue Oct 8, 2019

Upgrade to scala 2.13.1 taig/babel#27

Merged

takayahilton mentioned this issue Oct 8, 2019

update travis.yml lemonlabsuk/scala-uri#66

Merged

anskarl mentioned this issue Oct 8, 2019

Scala 2.13 support mdedetrich/akka-streams-json#6

Merged

Christewart mentioned this issue Oct 13, 2019

Bump scalac version to 2.13.1 bitcoin-s/bitcoin-s#747

Merged

nrinaudo mentioned this issue Oct 13, 2019

Breaks under 2.13.1 scalameta/mdoc#195

Closed

nrinaudo mentioned this issue Oct 16, 2019

Fix Scala 2.13.1 integration #299

Closed

0xRoch mentioned this issue Oct 17, 2019

Update Default Scoverage Version #300

Merged

rtyley mentioned this issue Oct 21, 2019

Add Scala 2.13 support DanielaSfregola/twitter4s#275

Merged

purrgrammer mentioned this issue Oct 25, 2019

Update Travis config xebia-functional/fetch#230

Merged

labra mentioned this issue Nov 17, 2019

Enable compilation and scoverage for scala 2.13.1 weso/utils#3

Open

francisdb added a commit to waylayio/kairosdb-scala that referenced this issue Nov 18, 2019

switch to scala 2.13.0 instead of 2.13.1

1ca58e6

scoverage is broken on 2.13.1 scoverage/sbt-scoverage#295

0xRoch closed this as completed in #300 Nov 19, 2019

denisrosset mentioned this issue Nov 25, 2019

[WIP] Update sbt-scoverage to 1.6.1 typelevel/spire#850

Closed

sideeffffect mentioned this issue Dec 3, 2019

Error validation transformer (VTransformer) scalalandio/chimney#120

Closed

alejgh mentioned this issue Apr 3, 2020

[SLI-0046] Build status of master is failing weso/shex-lite#46

Closed

vmencik mentioned this issue Jun 8, 2020

Release version compatible with Scala 2.13.2 #308

Closed

danny-goldberg-rally added a commit to danny-goldberg-rally/scalacheck-ops that referenced this issue Jan 26, 2021

downgrade 2.13 (scoverage/sbt-scoverage#295)

5e606eb

danny-goldberg-rally added a commit to danny-goldberg-rally/scalacheck-ops that referenced this issue Jan 26, 2021

Revert "downgrade 2.13 (scoverage/sbt-scoverage#295)"

dc6b603

This reverts commit 5e606eb.

csaltos mentioned this issue Feb 15, 2021

Upgrade to scalac 2.12.13 bitcoin-s/bitcoin-s#2509

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build failure with Scala 2.13.1 #295

Build failure with Scala 2.13.1 #295

plokhotnyuk commented Sep 18, 2019

ILLKO commented Sep 18, 2019

gslowikowski commented Sep 19, 2019

lrytz commented Sep 20, 2019

Christewart commented Sep 23, 2019

regis-leray commented Oct 9, 2019

nrinaudo commented Oct 9, 2019

leonardehrenfried commented Oct 9, 2019

nrinaudo commented Oct 14, 2019 •

edited

Loading

leonardehrenfried commented Oct 14, 2019

nrinaudo commented Oct 15, 2019

nrinaudo commented Oct 16, 2019 •

edited

Loading

polomarcus commented Apr 28, 2020

asavelyev01 commented Mar 11, 2021

eugeniyk commented Mar 19, 2021

Build failure with Scala 2.13.1 #295

Build failure with Scala 2.13.1 #295

Comments

plokhotnyuk commented Sep 18, 2019

ILLKO commented Sep 18, 2019

gslowikowski commented Sep 19, 2019

lrytz commented Sep 20, 2019

Christewart commented Sep 23, 2019

regis-leray commented Oct 9, 2019

nrinaudo commented Oct 9, 2019

leonardehrenfried commented Oct 9, 2019

nrinaudo commented Oct 14, 2019 • edited Loading

leonardehrenfried commented Oct 14, 2019

nrinaudo commented Oct 15, 2019

nrinaudo commented Oct 16, 2019 • edited Loading

polomarcus commented Apr 28, 2020

asavelyev01 commented Mar 11, 2021

eugeniyk commented Mar 19, 2021

nrinaudo commented Oct 14, 2019 •

edited

Loading

nrinaudo commented Oct 16, 2019 •

edited

Loading