Feature/270 full dv guidance scenario #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianHammerl
force-pushed
the
feature/270-full-dv-guidance-scenario
branch
2 times, most recently
from
b61eadd
to
abc4dad
Compare
thibaudteil
approved these changes
Aug 20, 2023
JulianHammerl
force-pushed
the
feature/270-full-dv-guidance-scenario
branch
from
abc4dad
to
754e081
Compare
The conditions for BSK_ERROR messages for mu and the transfer time (time between maneuver time and final time) are changed to accept mu and transfer time being equal to 0. This prevents error messages in BSK-Sims when the Lambert modules are created (automatically) but not configured (in case they are not used).
JulianHammerl
force-pushed
the
feature/270-full-dv-guidance-scenario
branch
from
754e081
to
d708583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A BSK-Sim scenario was created that illustrates the the usage of the Lambert modules for the first and second maneuver of the Lambert transfer arc. The LambertPlanner and LambertValidator modules were refactored slightly to prevent unnecessary BSK_ERROR messages for other BSK-Sim scenarios that automatically create the Lambert modules but do not configure them because they are not used.
The commits are organized the following way:
Verification
This scenario combines and illustrates the five modules lambertPlanner, lambertSolver, lambertValidator, lambertSurfaceRelativeVelocity and lambertSecondDV, all of which include their own UnitTest. This BSK-Sim scenario only connects these modules, so no test is included.
Documentation
Nothing was invalidated.
Future work
None.