Feature/300 closed loop dv scenario #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudteil
reviewed
Aug 16, 2023
src/fswAlgorithms/orbitControl/lambertPlanner/lambertPlanner.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/orbitControl/lambertValidator/lambertValidator.cpp
Outdated
Show resolved
Hide resolved
JulianHammerl
force-pushed
the
feature/300-closed-loop-DV-scenario
branch
4 times, most recently
from
54ca122
to
1435bd3
Compare
thibaudteil
approved these changes
Aug 20, 2023
JulianHammerl
force-pushed
the
feature/300-closed-loop-DV-scenario
branch
2 times, most recently
from
f602111
to
15a998f
Compare
JulianHammerl
force-pushed
the
feature/300-closed-loop-DV-scenario
branch
from
15a998f
to
bab261c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A BSK-Sim scenario was created that illustrates the the closed loop performance of the dv guidance modules (attitude control and maneuver execution) for Delta-V maneuvers.
The commits are organized the following way:
Reviewers should be aware that this branch is based off of the Ticket 270 branch (#122 ), so the #122 PR should be merged first.
Verification
All modules used by this scenario include their own unit tests, so no test was included for this scenario. Only the dvExecuteGuidance does not include a unit test, but a future ticket was created to add a unit test for that module.
Documentation
Nothing was invalidated.
Future work
The thrFiringRemainder and dvExecuteGuidance modules will be refactored.