Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake download bsp #328

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Cmake download bsp #328

merged 6 commits into from
Sep 14, 2024

Conversation

patkenneally
Copy link
Collaborator

Description

The first two commits update the github pull-request action to use Ubuntu 24 and the default github developed repo clone action.

The third commit uses CMake's file download feature to grab the de430.bsp and outputs helpful error information upon failure (e.g. Host could not be found, Timeout, etc.). Finally, the bsp files are removed from the repo.

Verification

CI and tests are run.

Documentation

NA

Future work

None

Copy link
Collaborator

@thibaudteil thibaudteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long awaited

@patkenneally patkenneally merged commit 0daf027 into develop Sep 14, 2024
3 checks passed
@patkenneally patkenneally deleted the ci/cmake-download-bsp branch September 14, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants