-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial release of lava-dnf v0.1.0 #8
Conversation
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
…st_ports Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
…ented) Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
…ean returns Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
…change shape. Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't go through all files. Looks really good @lava-dnf team.
…to v0.1.0 � Conflicts: � src/lava/lib/dnf/utils/plotting.py
Merge and unit tests depend on PR#96 and changes to Dense in lava-nc/lava. |
Signed-off-by: Mathis Richter <[email protected]>
I have not really had a chance to review the code much. It all looks really nice and polished. |
I am adhering to the flake8 type annotations checks. I also feel that the
Although ANN101 (type annotations for function arguments) and E501 (line length) seem important to have. |
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Starting the code review process of the initial release of lava-dnf v0.1.0.
Since there is a lot of code, I am doing this now already.
The following things still need to be changed - which we will hopefully be able to do tomorrow:
Plotting needs to be integrated. This will be based on the Monitor feature that is awaiting code review in lava-nc/lava.The tutorial has to be finished with inputs and plots.Multiple unit tests are currently skipped because they have non-deterministic behavior. We are looking into that.init.py files have to be changed to the new convention.Unit tests are currently failing because requirements.txt is depending on the last Lava release 0.1.1 rather than the current version in the repository.All comments start with non-capitalized letters - I will change that, no need to remark on every instance.The modules that need the most critical review are:
I suggest you pick one of these modules and also go through its unit tests rather than trying to cover all the code.
If you want to get an overview of how the user is supposed to use the whole thing, have a look at the tutorial (lava-dnf/tutorials/lava/lib/dnf/tutorial_dnf_101.ipynb) and the acceptance tests (lava-dnf/tests/lava/lib/dnf/acceptance).