Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd release of messaging refactor #407

Open
wants to merge 206 commits into
base: main
Choose a base branch
from

Conversation

killight98
Copy link

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

hexu33 and others added 30 commits August 5, 2022 12:02
Initialize cpp_message_infrastruture folder for development
* add cpplint dependence and add cpp scan into lint task
* ignore cpplint fail

Signed-off-by: luoxiaoc <[email protected]>
…inal message_infrastructure folder to depricated_message_infrastructure
Add abstract class details for shmem channel and ports
* Add const qualifier for constant

* Fix cpplint warnings

* Modify cpplint command for new project structure

* Update ci-build.yml
1. Move csrc to message_infrastructure/csrc
2. Modify CMakeLists.txt and *_py_wrapper.cc to enable build first
3. Update ci-build.yml
Update message infrastructure project folder:
* setup sub-project message-infrastructure
* install pybind11 by poetry

Signed-off-by: luoxiaoc <[email protected]>
* Copy the python file from depricated_message_infrastructure/*.py

* change multiprocessing.py to adapt interface

* fix cpplint error

* Update cpplib side MultiProcessing:
1. message_infrastructure_logging.h: logging for development
2. abstract_actor.h&posix_actor.cc: achieve stop function for signal
3. shm.h: Add SharedMemoryManager to cpplib
4. others: Update CMake, test and fix some type error'

fix pylint error

* Fix MultiProcessing Error and Cpplint Error

* Remove Actor interface for python

* Fix package path error

* Update API Interface
1. multiprocessing.py: Fix bug for sharedmemmanager name
2. remove lava package dependency for message_infrastructure
3. multiprocessing.cc: Add shmm and actors function
4. abstract_actor.h: Modify the posix actor and interface design
5. add and update test for multiprocessing

Signed-off-by: Miao, Hongda <[email protected]>

* Update import from message_infrastructure:
1. Move message_interface_enum.py to message_infrastructure
2. Update import syntax
3. Others: change multiprocessing init

Signed-off-by: Miao, Hongda <[email protected]>

* Update test_runtime.py import

Signed-off-by: Miao, Hongda <[email protected]>

* Update bash setenv.sh to add message_infrastructure

Signed-off-by: Miao, Hongda <[email protected]>
* Adding preliminary ports

* Added CppPort and CppIOPort

* Add preliminary classes for CppInPorts and CppOutPorts

* Add preliminary code for CppRefPorts

* Added preliminary CppVarPort class

* Add derived classes for CppVarPort

* Update namespace naming

* Fix linting issues

* Updated pybind11 for numpy arrays

* Fixed cpplint issues

* Added lambda functions

* Fix linting issues in Ports.h and Abstract Port cc file

* Added Python wrapper functions

* Added Pybind dtype for AbstractPortImplementation

* Added tranformer header file

* Updated transformers with parameters

* Add missing include in PyWrapper

* Add namespace for ports.cc

* Add different types of Read()

* Add transformer include and null to constants

* Swap naming of classes in PyWrapper

* Test variant on return types

* Added Python wrapper for transformer class

* Comment out Out/Ref/VarPorts for debugging

* Change to use template for Recv and Peek (CppInPort)

* Using pointers for constants

* Updated templates for all ports

* Fixed issue with vectors

* Fix linting issue

* Uncomment in PyWrapper

* Add AbstractPort, Port and Transformer to CMakeLists

Co-authored-by: shaline-koh <[email protected]>
Signed-off-by: hexu1 <[email protected]>
Co-authored-by: Miao, Hongda <[email protected]>
Co-authored-by: Luo Xiaochuan <[email protected]>
Co-authored-by: Wen Jie Seow <[email protected]>
Co-authored-by: shaline-koh <[email protected]>
hexu33 and others added 7 commits March 27, 2023 02:50
* add probe feature for dds

* move two dds constructors to wraper

* add explaination comment for default nbytes

---------

Signed-off-by: szc321 <[email protected]>
Signed-off-by: szc321 <[email protected]>
Co-authored-by: Xu, He <[email protected]>
Co-authored-by: luoxiaoc <[email protected]>
- add SelectorSleepNs
- optimize selector based on QUBO and SNN

Signed-off-by: luoxiaoc <[email protected]>
@hexu33 hexu33 force-pushed the messaging_refactor_release2nd branch from af35d6d to f5b9076 Compare June 19, 2023 10:15
hexu33 and others added 18 commits June 19, 2023 10:42
Signed-off-by: szc321 <[email protected]>
Signed-off-by: szc321 <[email protected]>
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
Signed-off-by: Marcus G K Williams <Marcus G K Williams [email protected]>
@tim-shea
Copy link
Contributor

@mgkwill @mathisrichter I propose to close this PR as not merge-able (keeping the branch of course, in case there's some code that can be rescued in the future). Is that okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.