Expose channel slack parameter to user interface #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
joyeshmishra
reviewed
Dec 7, 2022
src/lava/magma/runtime/runtime_services/channel_broker/channel_broker.py
Outdated
Show resolved
Hide resolved
joyeshmishra
approved these changes
Dec 7, 2022
ysingh7
approved these changes
Dec 7, 2022
Signed-off-by: Mathis Richter <[email protected]>
Signed-off-by: Mathis Richter <[email protected]>
mgkwill
approved these changes
Jan 3, 2023
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Exposed channel slack parameter to user interface. Signed-off-by: Mathis Richter <[email protected]> * Fully exposed channel slack parameter to user interface. Signed-off-by: Mathis Richter <[email protected]> * Removed debug output. Signed-off-by: Mathis Richter <[email protected]> * Added missing slack parameter. Signed-off-by: Mathis Richter <[email protected]> * Renamed 'slack' parameter to 'channel_slack'. Signed-off-by: Mathis Richter <[email protected]> Signed-off-by: Mathis Richter <[email protected]> Co-authored-by: PhilippPlank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request: This PR exposes the
slackparameter of channels to the user. Setting this parameter is required when creating CProcModels with many ports.Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information