Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose channel slack parameter to user interface #529

Merged
merged 10 commits into from
Jan 13, 2023
Merged

Expose channel slack parameter to user interface #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8b610c8
Exposed channel slack parameter to user interface.
mathisrichter Dec 7, 2022
1d19484
Merge branch 'main' of https://github.com/lava-nc/lava into slack_exp…
mathisrichter Dec 7, 2022
25d3255
Fully exposed channel slack parameter to user interface.
mathisrichter Dec 7, 2022
bb1730b
Removed debug output.
mathisrichter Dec 7, 2022
20feead
Added missing slack parameter.
mathisrichter Dec 7, 2022
bd0915a
Renamed 'slack' parameter to 'channel_slack'.
mathisrichter Dec 8, 2022
001dbd1
Merge branch 'main' into slack_exposure
PhilippPlank Dec 9, 2022
fd6727b
Merge branch 'main' of https://github.com/lava-nc/lava into slack_exp…
mathisrichter Dec 19, 2022
45ac5b5
Merge branch 'slack_exposure' of https://github.com/lava-nc/lava into…
mathisrichter Dec 19, 2022
7b53449
Merge branch 'main' of https://github.com/lava-nc/lava into slack_exp…
mathisrichter Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lava/magma/compiler/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,7 @@ def _create_runtime_service_builder(
model_ids,
loihi_version,
log.level,
compile_config,
**rs_kwargs
)
rs_builders[sync_domain] = rs_builder
Expand Down
15 changes: 12 additions & 3 deletions src/lava/magma/runtime/runtime_services/channel_broker/channel_broker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ class ChannelBroker(AbstractChannelBroker):

def __init__(self,
board: NxBoard,
compile_config: ty.Optional[ty.Dict[str, ty.Any]] = None,
*args,
**kwargs,):
"""Initialize ChannelBroker with NxBoard.
Expand All @@ -89,6 +90,7 @@ def __init__(self,
"""
super().__init__(*args, **kwargs)
self.board = board
self._compile_config = compile_config
self.has_started: bool = False
# Need to poll for CInPorts
self.c_inports_to_poll: ty.Dict[CInPort, Channel] = {}
Expand Down Expand Up @@ -170,11 +172,13 @@ def _create_channel(self,
channel_name: str,
message_size: int,
number_elements: int,
slack: int,
host_idx: int = 0):
return self.board.hosts[host_idx].createChannel(
name=channel_name,
messageSize=message_size,
numElements=number_elements
numElements=number_elements,
slack=slack
)

def create_channel(self,
Expand All @@ -185,6 +189,9 @@ def create_channel(self,
c_builder_idx: int) -> ty.List[Channel]:
channels: ty.List[Channel] = []
MESSAGE_SIZE_IN_C = 128 * 4
DEFAULT_CHANNEL_SLACK = 16
channel_slack = self._compile_config.get("channel_slack",
DEFAULT_CHANNEL_SLACK)
if input_channel:
for csp_port in c_port.csp_ports:
channel_name = generate_channel_name("in_grpc_",
Expand All @@ -194,7 +201,8 @@ def create_channel(self,
channels.append(self._create_channel(
channel_name=channel_name,
message_size=MESSAGE_SIZE_IN_C,
number_elements=csp_port.size
number_elements=csp_port.size,
slack=channel_slack
))
else:
for csp_port in c_port.csp_ports:
Expand All @@ -205,7 +213,8 @@ def create_channel(self,
channels.append(self._create_channel(
channel_name=channel_name,
message_size=MESSAGE_SIZE_IN_C,
number_elements=csp_port.size
number_elements=csp_port.size,
slack=channel_slack
))

if input_channel:
Expand Down