Fixed pylint errors #644

mathisrichter · 2023-02-26T11:35:48Z

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

Issue created that explains the change and why it's needed
Tests are part of the PR (for bug fixes / features)
Docs reviewed and added / updated if needed (for bug fixes / features)
PR conforms to Coding Conventions
PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
Build tests (pytest) passes locally

Pull request type

Please check your PR type:

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Yes
No

Supplemental information

Signed-off-by: Mathis Richter <[email protected]>

mgkwill · 2023-03-08T22:10:07Z

I'm not sure if you have fixed all the issues, but I suggest enabling this line to enforce in lint job in CI:

https://github.com/mathisrichter/lava/blob/d5d00632fef9c8adbd4b7a8167074436fec87e71/pyproject.toml#L173

and removing this line: https://github.com/mathisrichter/lava/blob/d5d00632fef9c8adbd4b7a8167074436fec87e71/pyproject.toml#L177

…nt_methods

Signed-off-by: Mathis Richter <[email protected]>

This reverts commit 8dc55a3.

Signed-off-by: Mathis Richter <[email protected]>

…nt_methods

Signed-off-by: Mathis Richter <[email protected]>

…nt_methods

Signed-off-by: Mathis Richter <[email protected]>

…r/lava into no_argument_methods

Signed-off-by: Mathis Richter <[email protected]>

weidel-p

A lot of renaming, nothing too controversial.

* Refactoring methods without arguments into functions. Signed-off-by: Mathis Richter <[email protected]> * Raising ValueError instead of str. Signed-off-by: Mathis Richter <[email protected]> * Defining members before use. Signed-off-by: Mathis Richter <[email protected]> * Fixed pylint error about non-callable variable. Signed-off-by: Mathis Richter <[email protected]> * Fixed deprecation warning. Signed-off-by: Mathis Richter <[email protected]> * Defined members before use. Signed-off-by: Mathis Richter <[email protected]> * Removed unused imports. Signed-off-by: Mathis Richter <[email protected]> * Removed unused variables. Signed-off-by: Mathis Richter <[email protected]> * Removed unnecessary pass statements. Signed-off-by: Mathis Richter <[email protected]> * Fixed attributes defined outside __init__. Signed-off-by: Mathis Richter <[email protected]> * Activated linting checks in poetry. Signed-off-by: Mathis Richter <[email protected]> * Revert "Refactoring methods without arguments into functions." This reverts commit 8dc55a3. * Deactivated flake8 plugins for now. Signed-off-by: Mathis Richter <[email protected]> * Fixed shadowing of built-in variable names. Signed-off-by: Mathis Richter <[email protected]> * Fixed reimported modules. Signed-off-by: Mathis Richter <[email protected]> * Explicitly disabling plugins again. Signed-off-by: Mathis Richter <[email protected]> * Fixed pointless string statement errors. Signed-off-by: Mathis Richter <[email protected]> * Fixed linter errors for abstract methods. Signed-off-by: Mathis Richter <[email protected]> * Fixed renamed arguments. Signed-off-by: Mathis Richter <[email protected]> * Fixed calling init method of non-parent class. Signed-off-by: Mathis Richter <[email protected]> * Fixed unit tests. Signed-off-by: Mathis Richter <[email protected]> * Ignored linter errors with subprocess module. Signed-off-by: Mathis Richter <[email protected]> * Ignored linter error about renamed variable. Signed-off-by: Mathis Richter <[email protected]> * Added a description on linter ignore. Signed-off-by: Mathis Richter <[email protected]> * Ignored arguments-differ linter error. Signed-off-by: Mathis Richter <[email protected]> * Fixed unused-variable linter error. Signed-off-by: Mathis Richter <[email protected]> * Fixed linter errors. Signed-off-by: Mathis Richter <[email protected]> * Reverted linter changes in runtime to fix unit tests in lava-loihi. Signed-off-by: Mathis Richter <[email protected]> * Fixed remark issues in Markdown files. Signed-off-by: Mathis Richter <[email protected]> * Fixed remark issues in Markdown files. Signed-off-by: Mathis Richter <[email protected]> * Fixed remark issues in Markdown files. Signed-off-by: Mathis Richter <[email protected]> --------- Signed-off-by: Mathis Richter <[email protected]>

mathisrichter added 4 commits February 25, 2023 16:29

Refactoring methods without arguments into functions.

8dc55a3

Signed-off-by: Mathis Richter <[email protected]>

Raising ValueError instead of str.

f07e890

Signed-off-by: Mathis Richter <[email protected]>

Defining members before use.

7329baa

Signed-off-by: Mathis Richter <[email protected]>

Fixed pylint error about non-callable variable.

d5d0063

Signed-off-by: Mathis Richter <[email protected]>

mathisrichter self-assigned this Feb 26, 2023

mgkwill self-requested a review March 8, 2023 22:10

mathisrichter added 9 commits May 6, 2023 18:14

Merge branch 'main' of https://github.com/lava-nc/lava into no_argume…

c941cd5

…nt_methods

Fixed deprecation warning.

d6c702b

Signed-off-by: Mathis Richter <[email protected]>

Defined members before use.

9133f25

Signed-off-by: Mathis Richter <[email protected]>

Removed unused imports.

da57ff9

Signed-off-by: Mathis Richter <[email protected]>

Removed unused variables.

4fed421

Signed-off-by: Mathis Richter <[email protected]>

Removed unnecessary pass statements.

4973e54

Signed-off-by: Mathis Richter <[email protected]>

Fixed attributes defined outside __init__.

f8f7b0c

Signed-off-by: Mathis Richter <[email protected]>

Activated linting checks in poetry.

39b829f

Signed-off-by: Mathis Richter <[email protected]>

Revert "Refactoring methods without arguments into functions."

1efa83e

This reverts commit 8dc55a3.

mathisrichter changed the title ~~Fixed various critical pylint errors~~ Fixed pylint errors May 8, 2023

mathisrichter added 12 commits May 8, 2023 11:47

Deactivated flake8 plugins for now.

4d9aff3

Signed-off-by: Mathis Richter <[email protected]>

Fixed shadowing of built-in variable names.

4af90ef

Signed-off-by: Mathis Richter <[email protected]>

Fixed reimported modules.

dfcee1b

Signed-off-by: Mathis Richter <[email protected]>

Explicitly disabling plugins again.

22f4802

Signed-off-by: Mathis Richter <[email protected]>

Fixed pointless string statement errors.

3479862

Signed-off-by: Mathis Richter <[email protected]>

Fixed linter errors for abstract methods.

c1c24b8

Signed-off-by: Mathis Richter <[email protected]>

Fixed renamed arguments.

7e4f403

Signed-off-by: Mathis Richter <[email protected]>

Fixed calling init method of non-parent class.

6810666

Signed-off-by: Mathis Richter <[email protected]>

Fixed unit tests.

38fa4cc

Signed-off-by: Mathis Richter <[email protected]>

Ignored linter errors with subprocess module.

f6fcc63

Signed-off-by: Mathis Richter <[email protected]>

Ignored linter error about renamed variable.

aa8632b

Signed-off-by: Mathis Richter <[email protected]>

Added a description on linter ignore.

71cf62d

Signed-off-by: Mathis Richter <[email protected]>

mathisrichter requested a review from gkarray May 19, 2023 12:12

mathisrichter added 2 commits May 19, 2023 15:12

Ignored arguments-differ linter error.

bfde547

Signed-off-by: Mathis Richter <[email protected]>

Fixed unused-variable linter error.

a4580cc

Signed-off-by: Mathis Richter <[email protected]>

mathisrichter marked this pull request as ready for review May 19, 2023 17:16

mathisrichter added 7 commits May 19, 2023 19:17

Merge branch 'main' of https://github.com/lava-nc/lava into no_argume…

8a7927a

…nt_methods

Fixed linter errors.

4ff8ef8

Signed-off-by: Mathis Richter <[email protected]>

Merge branch 'main' of https://github.com/lava-nc/lava into no_argume…

f844501

…nt_methods

Reverted linter changes in runtime to fix unit tests in lava-loihi.

f71f3d2

Signed-off-by: Mathis Richter <[email protected]>

Merge branch 'main' into no_argument_methods

5937131

Merge branch 'main' into no_argument_methods

458899a

Fixed remark issues in Markdown files.

e02062c

Signed-off-by: Mathis Richter <[email protected]>

PhilippPlank approved these changes May 26, 2023

View reviewed changes

mathisrichter added 3 commits May 26, 2023 11:40

Merge branch 'no_argument_methods' of https://github.com/mathisrichte…

73e81a6

…r/lava into no_argument_methods

Fixed remark issues in Markdown files.

cb26d7f

Signed-off-by: Mathis Richter <[email protected]>

Fixed remark issues in Markdown files.

4918f83

Signed-off-by: Mathis Richter <[email protected]>

weidel-p approved these changes May 26, 2023

View reviewed changes

mathisrichter merged commit f061d00 into lava-nc:main May 26, 2023

mathisrichter deleted the no_argument_methods branch May 26, 2023 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed pylint errors #644

Fixed pylint errors #644

mathisrichter commented Feb 26, 2023

mgkwill commented Mar 8, 2023 •

edited

Loading

weidel-p left a comment

Fixed pylint errors #644

Fixed pylint errors #644

Conversation

mathisrichter commented Feb 26, 2023

Pull request checklist

Pull request type

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Supplemental information

mgkwill commented Mar 8, 2023 • edited Loading

weidel-p left a comment

Choose a reason for hiding this comment

mgkwill commented Mar 8, 2023 •

edited

Loading