Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pylint errors #644

Merged
merged 37 commits into from
May 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
8dc55a3
Refactoring methods without arguments into functions.
mathisrichter Feb 25, 2023
f07e890
Raising ValueError instead of str.
mathisrichter Feb 25, 2023
7329baa
Defining members before use.
mathisrichter Feb 26, 2023
d5d0063
Fixed pylint error about non-callable variable.
mathisrichter Feb 26, 2023
c941cd5
Merge branch 'main' of https://github.com/lava-nc/lava into no_argume…
mathisrichter May 6, 2023
d6c702b
Fixed deprecation warning.
mathisrichter May 6, 2023
9133f25
Defined members before use.
mathisrichter May 6, 2023
da57ff9
Removed unused imports.
mathisrichter May 6, 2023
4fed421
Removed unused variables.
mathisrichter May 6, 2023
4973e54
Removed unnecessary pass statements.
mathisrichter May 7, 2023
f8f7b0c
Fixed attributes defined outside __init__.
mathisrichter May 8, 2023
39b829f
Activated linting checks in poetry.
mathisrichter May 8, 2023
1efa83e
Revert "Refactoring methods without arguments into functions."
mathisrichter May 8, 2023
4d9aff3
Deactivated flake8 plugins for now.
mathisrichter May 8, 2023
4af90ef
Fixed shadowing of built-in variable names.
mathisrichter May 8, 2023
dfcee1b
Fixed reimported modules.
mathisrichter May 8, 2023
22f4802
Explicitly disabling plugins again.
mathisrichter May 8, 2023
3479862
Fixed pointless string statement errors.
mathisrichter May 18, 2023
c1c24b8
Fixed linter errors for abstract methods.
mathisrichter May 18, 2023
7e4f403
Fixed renamed arguments.
mathisrichter May 18, 2023
6810666
Fixed calling init method of non-parent class.
mathisrichter May 18, 2023
38fa4cc
Fixed unit tests.
mathisrichter May 19, 2023
f6fcc63
Ignored linter errors with subprocess module.
mathisrichter May 19, 2023
aa8632b
Ignored linter error about renamed variable.
mathisrichter May 19, 2023
71cf62d
Added a description on linter ignore.
mathisrichter May 19, 2023
bfde547
Ignored arguments-differ linter error.
mathisrichter May 19, 2023
a4580cc
Fixed unused-variable linter error.
mathisrichter May 19, 2023
8a7927a
Merge branch 'main' of https://github.com/lava-nc/lava into no_argume…
mathisrichter May 19, 2023
4ff8ef8
Fixed linter errors.
mathisrichter May 19, 2023
f844501
Merge branch 'main' of https://github.com/lava-nc/lava into no_argume…
mathisrichter May 25, 2023
f71f3d2
Reverted linter changes in runtime to fix unit tests in lava-loihi.
mathisrichter May 26, 2023
5937131
Merge branch 'main' into no_argument_methods
mathisrichter May 26, 2023
458899a
Merge branch 'main' into no_argument_methods
mathisrichter May 26, 2023
e02062c
Fixed remark issues in Markdown files.
mathisrichter May 26, 2023
73e81a6
Merge branch 'no_argument_methods' of https://github.com/mathisrichte…
mathisrichter May 26, 2023
cb26d7f
Fixed remark issues in Markdown files.
mathisrichter May 26, 2023
4918f83
Fixed remark issues in Markdown files.
mathisrichter May 26, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,19 @@ Objective of issue:

**Lava version:**
<!-- remove versions not chosen below -->
- [ ] **0.6.0** (feature release)
- [ ] **0.5.1** (bug fixes)
- [x] **0.5.0** (current version)
- [ ] **0.4.1**
- [ ] **0.4.0**
- [ ] **0.3.0**
- [ ] **0.1.2**
- [ ] **0.6.0** (feature release)
- [ ] **0.5.1** (bug fixes)
- [x] **0.5.0** (current version)
- [ ] **0.4.1**
- [ ] **0.4.0**
- [ ] **0.3.0**
- [ ] **0.1.2**

**I'm submitting a ...**
<!-- (Mark one with "x") remove not chosen below -->
- [ ] bug report
- [ ] feature request
- [ ] documentation request
- [ ] bug report
- [ ] feature request
- [ ] documentation request

<!-- Please do not submit support requests or "How to" questions here, use discussions Q&A https://github.com/lava-nc/lava/discussions/categories/q-a -->

Expand Down
10 changes: 5 additions & 5 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ A clear and concise description of what the bug is.

**To reproduce current behavior**
Steps to reproduce the behavior:
1. When I run this code (add code or minimum test case) ...
1. When I run this code (add code or minimum test case) ...
```python
def my_code():
pass
```
2. I get this error ...
2. I get this error ...
```
Error...
```
Expand All @@ -39,9 +39,9 @@ A clear and concise description of what you expected to happen.
If applicable, add screenshots to help explain your problem. Remove section otherwise.

**Environment (please complete the following information):**
- Device: [e.g. Laptop, Intel cloud]
- OS: [e.g. Linux]
- Lava version [e.g. 0.6.1]
- Device: [e.g. Laptop, Intel cloud]
- OS: [e.g. Linux]
- Lava version [e.g. 0.6.1]

**Additional context**
Add any other context about the problem here. Remove section otherwise.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ assignees: ''
As a user, I want to [capability] to [benefit].

### Conditions of satisfaction
- An optional list of conditions that have to be fulfilled for this feature to be complete.
- For example: "Users can add both individual items and lists as parameters."
- An optional list of conditions that have to be fulfilled for this feature to be complete.
- For example: "Users can add both individual items and lists as parameters."

### Acceptance tests
- An optional list of tests that should be written to automatically test the new feature.
- An optional list of tests that should be written to automatically test the new feature.
32 changes: 16 additions & 16 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ Objective of pull request:
## Pull request checklist
<!-- (Mark with "x") -->
Your PR fulfills the following requirements:
- [ ] [Issue](https://github.com/lava-nc/lava/issues) created that explains the change and why it's needed
- [ ] Tests are part of the PR (for bug fixes / features)
- [ ] [Docs](https://github.com/lava-nc/docs) reviewed and added / updated if needed (for bug fixes / features)
- [ ] PR conforms to [Coding Conventions](https://lava-nc.org/developer_guide.html#coding-conventions)
- [ ] [PR applys BSD 3-clause or LGPL2.1+ Licenses](https://lava-nc.org/developer_guide.html#add-a-license) to all code files
- [ ] Lint (`flakeheaven lint src/lava tests/`) and (`bandit -r src/lava/.`) pass locally
- [ ] Build tests (`pytest`) passes locally
- [ ] [Issue](https://github.com/lava-nc/lava/issues) created that explains the change and why it's needed
- [ ] Tests are part of the PR (for bug fixes / features)
- [ ] [Docs](https://github.com/lava-nc/docs) reviewed and added / updated if needed (for bug fixes / features)
- [ ] PR conforms to [Coding Conventions](https://lava-nc.org/developer_guide.html#coding-conventions)
- [ ] [PR applys BSD 3-clause or LGPL2.1+ Licenses](https://lava-nc.org/developer_guide.html#add-a-license) to all code files
- [ ] Lint (`flakeheaven lint src/lava tests/`) and (`bandit -r src/lava/.`) pass locally
- [ ] Build tests (`pytest`) passes locally


## Pull request type
Expand All @@ -30,13 +30,13 @@ Your PR fulfills the following requirements:
Please check your PR type:
<!-- (Mark one with "x") remove not chosen below -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation changes
- [ ] Other (please describe):
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation changes
- [ ] Other (please describe):


## What is the current behavior?
Expand All @@ -50,8 +50,8 @@ Please check your PR type:
## Does this introduce a breaking change?
<!-- (Mark one with "x") remove not chosen below -->

- [ ] Yes
- [ ] No
- [ ] Yes
- [ ] No

<!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. -->

Expand Down
29 changes: 10 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,13 @@ supporting architectures like Intel Loihi may remain proprietary
to Intel and will be shared as extensions to eligible users.

>### Lava extension for Intel's Loihi
>The Lava extension for Loihi is available for members of the Intel
Neuromorphic Research Community (INRC). The extension enables execution of
Lava on Intel's Loihi hardware platform.
>The Lava extension for Loihi is available for members of the Intel Neuromorphic Research Community (INRC). The extension enables execution of Lava on Intel's Loihi hardware platform.
>
>Developers interested in using Lava with Loihi systems need to join the
INRC. Loihi 1 and 2 research systems are currently not available
commercially. Once a member of the INRC, developers will gain access to
cloud-hosted Loihi systems or may be able to obtain physical Loihi systems on a
loan basis.
>Developers interested in using Lava with Loihi systems need to join the INRC. Loihi 1 and 2 research systems are currently not available commercially. Once a member of the INRC, developers will gain access to cloud-hosted Loihi systems or may be able to obtain physical Loihi systems on a loan basis.
>
>To join the INRC, visit [http://neuromorphic.intel.com](http://neuromorphic.intel.com)
or email at [[email protected]](mailto:[email protected]).
>To join the INRC, visit [http://neuromorphic.intel.com](http://neuromorphic.intel.com) or email at [[email protected]](mailto:[email protected]).
>
> If you are already a member of the INRC, please read how to [get
started with the Lava extension for Loihi.](https://intel-ncl.atlassian.net/wiki/spaces/NAP/pages/1785856001/Get+started+with+the+Lava+extension+for+Loihi)
> This page is **only** accessible to members of the INRC.
> If you are already a member of the INRC, please read how to [get started with the Lava extension for Loihi](https://intel-ncl.atlassian.net/wiki/spaces/NAP/pages/1785856001/Get+started+with+the+Lava+extension+for+Loihi). This page is **only** accessible to members of the INRC.

# Getting started
Expand All @@ -70,7 +61,7 @@ will need to install the `poetry` Python package.

Open a **python 3** terminal and run based on the OS you are on:

### [Linux/MacOS]
### Linux/MacOS

```bash
cd $HOME
Expand All @@ -87,7 +78,7 @@ pytest
## See FAQ for more info: https://github.com/lava-nc/lava/wiki/Frequently-Asked-Questions-(FAQ)#install
```

### [Windows]
### Windows

```powershell
# Commands using PowerShell
Expand Down Expand Up @@ -140,7 +131,7 @@ Required test coverage of 85.0% reached. Total coverage: 88.81%
```

## [Alternative] Installing Lava via Conda
## Alternative: Installing Lava via Conda

If you use the Conda package manager, you can simply install the Lava package
via:
Expand All @@ -158,7 +149,7 @@ conda install -n lava -c intel numpy scipy
conda install -n lava -c conda-forge lava --freeze-installed
```

## [Alternative] Installing Lava from binaries
## Alternative: Installing Lava from binaries

If you only need to install Lava as a user in your python environment, we will
publish Lava releases via
Expand All @@ -167,7 +158,7 @@ the package and install it.

Open a Python terminal and run:

### [Windows/MacOS/Linux]
### Windows/MacOS/Linux

```bash
python -m venv .venv
Expand Down Expand Up @@ -203,7 +194,7 @@ bandit -r src/lava/.
bandit -r src/lava/. --format custom --msg-template '{abspath}:{line}: {test_id}[bandit]: {severity}: {msg}'
```
##
> Refer to the tutorials directory for in-depth as well as end-to-end tutorials on how to write Lava Processes, connect them, and execute the code.
>Refer to the tutorials directory for in-depth as well as end-to-end tutorials on how to write Lava Processes, connect them, and execute the code.
# Stay in touch

Expand Down
Loading