Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/custom voting #198

Merged
merged 11 commits into from
Nov 12, 2024
Merged

Feat/custom voting #198

merged 11 commits into from
Nov 12, 2024

Conversation

lagartoverde
Copy link
Contributor

@lagartoverde lagartoverde commented Oct 15, 2024

Overview

Add supporting models for the custom voting PR

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4991
lblod/frontend-gelinkt-notuleren#732

How to test/reproduce

Better to test with the frontend PR

Challenges/uncertainties

None

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@abeforgit
Copy link
Member

for reviewers: needs lblod/notulen-prepublish-service#115

@abeforgit abeforgit merged commit adf8f7a into master Nov 12, 2024
@abeforgit abeforgit deleted the feat/custom-voting branch November 12, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants