Feat/manual voting #732
Merged
Feat/manual voting #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
abeforgit
requested changes
Oct 22, 2024
There was a problem hiding this comment.
bug:
- add custom voting to an ap which doesn't have participants configured
- voting doesn't get added, but participant button is now greyed out
bug:
- you can now add a normal voting even if there are no participants, which was previously not allowed (and also doesn't work when you try to save the voting)
bug:
my browser is in dutch, but "custom voting" is not translated
bug:
pill not aligned nicely
bug:
in general could use a bit of padding or something to make it clear this is an input field
bug:
- edit title, and directly click on meeting "save" button
- "saved" pill shows, but title is not changed
bug:
"save" button does nothing, only "save and quit" works
bug:
not sure what's going on here:
|
Fixed all bugs and made a custom view for published votings |
abeforgit
requested changes
Oct 28, 2024
abeforgit
requested changes
Oct 28, 2024
There was a problem hiding this comment.
saving title is still broken:
repro 1:
- reset cache to get a consistent state
- change title, don't click the checkmark
- click the save (not the save&quit) button
- exit the document
- notice title is not changed
- page refresh and cache restart don't help
repro 2:
- change title
- don't click checkmark
- now click "save&quit"
- notice title still hasn't changed in overview
- refresh: now title is changed in overview
- BUT: open document: notice title is not changed there
- restart cache
- now title is changed in both places
abeforgit
requested changes
Oct 31, 2024
|
added a commit to fix the person plugin after I merged master, as we no longer use the vendor-proxy (it was also broken before though, as it was missing the nodespec in the config 😬 ) |
…t-notuleren into feat/manual-voting
|
Fixed that bug, hopefully is the last one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added a way to add a custom voting to the behandeling that will be just a document
connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-4991
lblod/app-gelinkt-notuleren#198
Setup
You should use the lblod/app-gelinkt-notuleren#198 as backend
How to test/reproduce
Go to the meeting form, and notice that you should be able to add custom votings that just let you write some text in the a document
Challenges/uncertainties
We should maybe add some extra rdfa in the document, I will have a look when I finish the prepublisher and see how the final document looks like
As I said the prepublisher is not finished, so that's something I have to finish before merging this PR
Checks PR readiness