GN-4159 - Feature/create revoke signature button

[lagartoverde]

No description provided.

[lagartoverde]

Should solve https://binnenland.atlassian.net/browse/GN-4158 and https://binnenland.atlassian.net/browse/GN-4159, it needs the PR lblod/notulen-prepublish-service#101 and lblod/app-gelinkt-notuleren#150

[abeforgit]

why all the model.get calls? that method is deprecated in ED 4.x, and even before it was not "supposed" to be used.

not tested, since this PR broke the signing button, but that could be something with my setup

[elpoelma]

reported by niels in rocket chat:

* toggle of people present at meeting is broken

* people present at voting don't load

* sign agenda as laarne writer, delete signature
  log out
  log in as laarne reader
  sign agenda
  -> error

first two probably related to ember data still EDIT: can not reproduce the first two EDIT: also can't repro the last but awaiting more testing

I reproduced the second issue (people present at voting don't load) when upgrading to ember-data 4.8, but I fixed it in that PR. I could not reproduce the error on ember data 3.28.13. The main issue was that the relation of people present at the meeting was not correctly awaited.

[elpoelma]

Signing the notulen should not prevent the use from switching whether a certain decision is published (included) in the notulen or not. It looks like this is no longer possible on this branch. At least it requires a manual refresh by the user.

Further more it looks like the signing takes the settings into account, where it was previously specified the whole document (all full decisions) should be signed at all times.

on master after signing:

on this branch after signing:

I was also able to reproduce the same issue, it only shows the toggle again after a full manual refresh. Will check if it occurs on master too.
EDIT: I wasn't able to reproduce it on master.

[elpoelma]

Seems to work well overall. The new publication actions page works as expected.
I could also reproduce some issues @nvdk noticed, including:

• the make public toggles no longer show up after signing notulen, they only show up after a manual browser refresh

I had no issues with removing a signature, signing out, signing in and adding a signature again.

[elpoelma]

Seems to work well overall. The new publication actions page works as expected. I could also reproduce some issues @nvdk noticed, including:

* the `make public` toggles no longer show up after signing notulen, they only show up after a manual browser refresh

I had no issues with removing a signature, signing out, signing in and adding a signature again.

The issue with the toggles not being displayed is because the Signatures::Notulen::BehandelingenList component in the notulen route is not being rendered after the signature addition/removal. This is due to the in-element helper not fully working as expected.

{{#in-element this.containerElement}}
      <Signatures::Notulen::BehandelingenList
        @notulen={{this.notulen}}
        @prepublishedBehandelingen={{this.treatments}}
        @publicBehandelingUris={{this.publicBehandelingUris}}
        @toggle={{this.togglePublicationStatus}}
        @toggleAll={{this.toggleAllPublicationStatus}}
        @allBehandelingPublic={{this.allBehandelingPublic}}
      />
{{/in-element}}

this.containerElement is correctly updated after the signature addition/removal, but the in-element helper does not pick this up and thus no longer renders the Signatures::Notulen::BehandelingenList component.

[elpoelma]

Seems to work well overall. The new publication actions page works as expected. I could also reproduce some issues @nvdk noticed, including:

* the `make public` toggles no longer show up after signing notulen, they only show up after a manual browser refresh

I had no issues with removing a signature, signing out, signing in and adding a signature again.

The issue with the toggles not being displayed is because the Signatures::Notulen::BehandelingenList component in the notulen route is not being rendered after the signature addition/removal. This is due to the in-element helper not fully working as expected.

{{#in-element this.containerElement}}
      <Signatures::Notulen::BehandelingenList
        @notulen={{this.notulen}}
        @prepublishedBehandelingen={{this.treatments}}
        @publicBehandelingUris={{this.publicBehandelingUris}}
        @toggle={{this.togglePublicationStatus}}
        @toggleAll={{this.toggleAllPublicationStatus}}
        @allBehandelingPublic={{this.allBehandelingPublic}}
      />
{{/in-element}}

this.containerElement is correctly updated after the signature addition/removal, but the in-element helper does not pick this up and thus no longer renders the Signatures::Notulen::BehandelingenList component.

The issues is that the containerElement property is not a tracked getter, so the in-element does not pick it up. Ideally, something like this:

get containerElement() {
    if (this.loadNotulen.isIdle) {
      return document.getElementById(this.behandelingContainerId);
    } else {
      return null;
    }
  }

should work. Not super clean, but it ensures that containerElement is tracked each time the loading state changes.

[nvdk]

@elpoelma wouldn't just making behandelingContainerId tracked work as well?

[elpoelma]

@elpoelma wouldn't just making behandelingContainerId tracked work as well?

The issue is that behandelingContainerId does not change.

[nvdk]

ah right 😅

[abeforgit]

So your suggestion works @elpoelma but I have no idea why since that whole block is already in an if-block that conditionally renders on the loadNotulen idle state

[elpoelma]

Seems to work well now, not encountering technical issues any longer. Just a note,

In the above page the margins of the back button are rather small, maybe we could increase it?

[abeforgit]

to save you some time, it looks like this now:

[elpoelma]

Good to go now :)