-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for delete signatures #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks legit based on my SPARQL knowledge (kinda bad still)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
currently only for treatments, needs testing
…/delete-signatures
linting fix in #102 if approved, if not will fix manually |
?uri sign:status ?blockchainStatus; | ||
sign:signatory ?signatory. | ||
|
||
?blockchainStatus mu:uuid ?blockchainStatusUuid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider blockchainStatus and uuid legacy and no longer required. little value in adding them as this hasn't been used in over 4 years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the interest of limiting scope, OK to leave it for now and open a separate pr to clean up obsolete stuff?
No description provided.