Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for delete signatures #101

Merged
merged 9 commits into from
Jun 8, 2023
Merged

Conversation

lagartoverde
Copy link
Collaborator

No description provided.

Copy link

@dkozickis dkozickis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit based on my SPARQL knowledge (kinda bad still)

Copy link
Contributor

@usrtim usrtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abeforgit
Copy link
Member

linting fix in #102 if approved, if not will fix manually

support/pre-importer.js Outdated Show resolved Hide resolved
?uri sign:status ?blockchainStatus;
sign:signatory ?signatory.

?blockchainStatus mu:uuid ?blockchainStatusUuid.
Copy link
Member

@nvdk nvdk Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider blockchainStatus and uuid legacy and no longer required. little value in adding them as this hasn't been used in over 4 years.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the interest of limiting scope, OK to leave it for now and open a separate pr to clean up obsolete stuff?

@abeforgit abeforgit requested a review from nvdk June 1, 2023 08:53
@abeforgit abeforgit merged commit 2380850 into master Jun 8, 2023
@abeforgit abeforgit deleted the feature/delete-signatures branch June 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants