Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update editor to latest dev commit #762

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Nov 7, 2024

Overview

This PR updates the editor to the dev commit corresponding with lblod/ember-rdfa-editor#1226.
It fixes a regression regarding the specificity of the general editor margin css rule.

connected issues and PRs:

lblod/ember-rdfa-editor#1226

Setup

None

How to test/reproduce

  • Start the app
  • Open an agendapoint containing a template comment
    Without this PR
  • The margins inside the template comment are not as expected:
    image

With this PR

  • The margins of the template comment are correct again:
    image

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma marked this pull request as ready for review November 7, 2024 14:31
@elpoelma elpoelma merged commit 9c65672 into master Nov 7, 2024
3 checks passed
@elpoelma elpoelma deleted the styling/specificity-regression branch November 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant