fix(styling): revert specificity of general editor margin rule to (0,1,1) #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a styling regression introduced in 10.7.0 wherein the specificity of the general editor margin css rule was increased from (0,1,1) to (0,2,1). This broke some styling in (among others) the plugins css.
This PR splits the general margin rule in two seperate rules, each with a specificity of (0,1,1).
connected issues and PRs:
None
Setup
#1224
lblod/frontend-reglementaire-bijlage#296
lblod/ember-rdfa-editor-lblod-plugins#499
How to test/reproduce
Check-out lblod/frontend-gelinkt-notuleren#762 or lblod/frontend-reglementaire-bijlage#296 on instructions how to test this PR.
Checks PR readiness