Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automated Build/Tests #14

Open
CameronDevine opened this issue Apr 13, 2024 · 7 comments
Open

Add Automated Build/Tests #14

CameronDevine opened this issue Apr 13, 2024 · 7 comments
Assignees

Comments

@CameronDevine
Copy link

As part of the JOSS review (openjournals/joss-reviews#6138) I think this repository should have an automated build, preferably with some tests.

@mhubii
Copy link
Member

mhubii commented May 13, 2024

agreed, thank you for the feedback!

@mhubii
Copy link
Member

mhubii commented Jul 4, 2024

I will try to find time to work on this soon. Any chance you could help out here a little @cmower? Or are you too occupied? No worries if not.

mhubii added a commit that referenced this issue Sep 7, 2024
@mhubii mhubii self-assigned this Sep 7, 2024
@mhubii
Copy link
Member

mhubii commented Sep 8, 2024

automatic builds are already added for Ubuntu 24.04 and 22.04. Currently missing are tests

@CameronDevine
Copy link
Author

I think automated builds alone should be sufficient as this repository primarily contains bindings.

@mhubii
Copy link
Member

mhubii commented Sep 12, 2024

thanks for the feedback @CameronDevine, I am in the process of writing an emulator for the robot to mimic its behavior. This should allow for simple testing by the end of the week.

@mhubii
Copy link
Member

mhubii commented Sep 13, 2024

maybe in the interest of time, is it possible to treat the procedural tests with virtual hardware separately from this review? I would then open new issues and reference this but keep JOSS untagged.

The progress of the emulator can be tracked here : https://github.com/lbr-stack/fri_emulator

@CameronDevine
Copy link
Author

I don't think closing this issue is required for me to recommend acceptance. @adi3 is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants