Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Upgrade on Close" doesn't close because multiple modals open #1747

Closed
tzarebczan opened this issue Jul 9, 2018 · 7 comments
Closed

"Upgrade on Close" doesn't close because multiple modals open #1747

tzarebczan opened this issue Jul 9, 2018 · 7 comments
Labels
area: devops type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

The Issue

If a user has the LBRY app open and an update is out, it will create a modal every 10 minutes. So if you try to click the "Upgrade on Close" button - it won't actually close because you need to click it multiple times.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@doniyor2109
Copy link
Contributor

I have tested "Upgrade on Close" button but it works as expected

@doniyor2109
Copy link
Contributor

What is the platform name that the case occurred?

@tzarebczan
Copy link
Contributor Author

@doniyor2109 - did you leave the app open more than 10/20 minutes? The upgrade on close stack up on one another when the updater checks for new updates. This would only happen on Mac/Windows.

@doniyor2109
Copy link
Contributor

I waited sometime nothing happened. I will wait sometime again

@tzarebczan
Copy link
Contributor Author

Nothing is meaning you weren't notified of an update or you didn't run into the modals stacking?

To reproduce, you must download an earlier version like https://github.com/lbryio/lbry-desktop/releases/tag/v0.22.2

@tzarebczan
Copy link
Contributor Author

@doniyor2109 you should be able to reproduce if you are on 0.23.0 (0.23.1 launched today) on Windows/Mac.

@doniyor2109
Copy link
Contributor

doniyor2109 commented Aug 6, 2018

@tzarebczan Sorry for late response. Can you check the PR for the issue? I have linux so I could not test it.

jessopb pushed a commit that referenced this issue Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: devops type: bug Existing functionality is wrong or broken
Projects
None yet
Development

No branches or pull requests

3 participants