-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Upgrade on Close" doesn't close because multiple modals open #1747
Comments
I have tested "Upgrade on Close" button but it works as expected |
What is the platform name that the case occurred? |
@doniyor2109 - did you leave the app open more than 10/20 minutes? The upgrade on close stack up on one another when the updater checks for new updates. This would only happen on Mac/Windows. |
I waited sometime nothing happened. I will wait sometime again |
Nothing is meaning you weren't notified of an update or you didn't run into the modals stacking? To reproduce, you must download an earlier version like https://github.com/lbryio/lbry-desktop/releases/tag/v0.22.2 |
@doniyor2109 you should be able to reproduce if you are on 0.23.0 (0.23.1 launched today) on Windows/Mac. |
@tzarebczan Sorry for late response. Can you check the PR for the issue? I have linux so I could not test it. |
The Issue
If a user has the LBRY app open and an update is out, it will create a modal every 10 minutes. So if you try to click the "Upgrade on Close" button - it won't actually close because you need to click it multiple times.
System Configuration
Anything Else
Screenshots
The text was updated successfully, but these errors were encountered: