Clear upgrade subscribed interval after declining #1857
Conversation
|
@doniyor2109 thanks for for this PR, please see https://lbry.io/faq/tips if you are interested in a tip for your contribution! Just looking at this by inspection, it may prevent new upgrade modals from popping up if the user clicked decline, but I don't think it prevents multiple upgrade modals from stacking on each other if a user has the app running in the background and an update occurs. |
This might do the trick, needs to be tested.
|
@tzarebczan How can I create new action for app actions? |
|
@doniyor2109 i just submitted a commit which should fix this issue, but haven't tested it yet. I'll let @seanyesmunt review first. |
|
@tzarebczan Ok |
Create action for clearing upgrade timer
|
@tzarebczan Can you merge lbryio/lbry-redux#66 and upgrade |
|
@doniyor2109 Looks good. I merged the lbry-redux PR and bumped the version in this PR. I'll give it a better test tomorrow before merging. Thanks for the contribution! |
|
Thanks again @doniyor2109, was able to test and it worked! |
|
@tzarebczan I am glad to help 👌 |
Closes #1747