-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share speech URLs on File and Channel pages #1222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good.
CHANGELOG.md
Outdated
@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). | |||
* App category for Linux ([#877](https://github.com/lbryio/lbry-app/pull/877)) | |||
* Add YouTube Sync reward ([#1147](https://github.com/lbryio/lbry-app/pull/1147)) | |||
* Retain previous screen sizing on startup ([#338](https://github.com/lbryio/lbry-app/issues/338)) | |||
* Add 'Go to page' input on channel pagination ([#1166](https://github.com/lbryio/lbry-app/pull/1166)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you request seems to be intertwined with another one somehow. Can you please figure out how to take out these pagination related changes?
@@ -4,6 +4,7 @@ import * as React from 'react'; | |||
import classnames from 'classnames'; | |||
|
|||
type Props = { | |||
centered?: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is from the pagination PR?
@@ -180,6 +183,14 @@ class FilePage extends React.Component<Props> { | |||
<SubscribeButton uri={subscriptionUri} channelName={channelName} /> | |||
</React.Fragment> | |||
)} | |||
{speechSharable && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you run yarn format
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did, and it did not change anything
src/renderer/page/file/view.jsx
Outdated
@@ -123,6 +123,9 @@ class FilePage extends React.Component<Props> { | |||
if (channelName && channelClaimId) { | |||
subscriptionUri = buildURI({ channelName, claimId: channelClaimId }, false); | |||
} | |||
const free = costInfo && costInfo.cost === 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does free
need to be its own variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to request changes
I am not sure what's going on with this conflict in What Github tells me is a problem on lines 54-58 is not a problem locally |
Can you rebase and get this up to date? |
30b5f95
to
d2a5d21
Compare
d2a5d21
to
c6732d3
Compare
@seanyesmunt Tired of adding buttons to the show page yet? haha Wonder how this fits in with your changes to file actions. I'll try to give it a whirl today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. I think the button placement is fine.
New PR for #1028 @tzarebczan @liamcardenas
This creates
<ViewOnWebButton>
with aGLOBE
icon and uses it on<FilePage>
and<ChannelPage>
Also fixes ~10 eslint errors