Resolve corejs3-shipped-proposals build issues. #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@babel/compat-data 7.8.6 to pre-7.10 series has compilation issues with newer node 12.x and 13.x releases. Using 7.8.6 will cause the failure to find the module `'@babel/compat-data/corejs3-shipped-proposals'`, causing build failures on systems with those node releases (e.g. Solus). This patch bumps @babel/preset-env, @babel/preset-flow, and @babel/preset-react specifically to newer releases to resolve compilation. Please note that this does not update all of babel to newer 7.10 series releases, just specifically resolves compilation on specific Linux platforms.
|
"At least during my short analysis there didn't appear to be any breaking changes." That's code for ship it. (I just came here to make that joke. Please be responsible, and thanks as always @JoshStrobl!) |
|
Thanks for opening this @JoshStrobl Were you seeing this in the released app? Or just in dev? |
|
@seanyesmunt I was seeing this with the 0.46.2 production release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/compat-data 7.8.6 to pre-7.10 series has compilation issues with newer node 12.x and 13.x releases.
PR Checklist
PR Type
What kind of change does this PR introduce?
Fixes
Using 7.8.6 will cause the failure to find the module
'@babel/compat-data/corejs3-shipped-proposals', causing build failures on systems with those node releases (e.g. Solus).This patch bumps @babel/preset-env, @babel/preset-flow, @babel/preset-react, and their deps specifically to newer releases to resolve compilation. Please note that this does not update all of babel to newer 7.10 series releases, just specifically resolves compilation on specific Linux platforms. Should LBRY folks want to upgrade fully to newer 7.10 series, that's probably something worth doing separately. At least during my short analysis there didn't appear to be any breaking changes.
This is already in use and validated via Solus: https://dev.getsol.us/R3654:1675cd3bb40d7d2f36483c9ebc5c0060ce3fe9f6
What is the current behavior?
Build failures under nodejs 12.18.0 on Solus
What is the new behavior?
Build success under nodejs 12.18.0 on Solus
Other information
Issues in other projects: