-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASR: Keep strings unescaped in AST, ASR #1762
Merged
Shaikh-Ubaid
merged 8 commits into
lcompilers:main
from
Shaikh-Ubaid:asr_unescaped_strings
May 7, 2023
Merged
ASR: Keep strings unescaped in AST, ASR #1762
Shaikh-Ubaid
merged 8 commits into
lcompilers:main
from
Shaikh-Ubaid:asr_unescaped_strings
May 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaikh-Ubaid
force-pushed
the
asr_unescaped_strings
branch
2 times, most recently
from
May 6, 2023 09:17
c2a45f1
to
17fa37d
Compare
Shaikh-Ubaid
force-pushed
the
asr_unescaped_strings
branch
3 times, most recently
from
May 6, 2023 10:26
8c4f55e
to
30d0f8a
Compare
Example: $ cat examples/expr2.py
def main0():
print(r"\n\t\r\
\n\t\
hi")
print('I said \'Wow\' ')
print("I said \"hi\" ")
print("I said \\\"hi\" ")
print("abc \\ ")
print("abc \\\ wow")
print('I said \'\\\'hi\\''hey\' ')
print(' ''hey\' ')
print(" " " hey\" ")
main0()
$ python examples/expr2.py
\n\t\r\
\n\t\
hi
I said 'Wow'
I said "hi"
I said \"hi"
abc \
abc \\ wow
I said '\'hi\hey'
hey'
hey"
$ lpython examples/expr2.py
\n\t\r\
\n\t\
hi
I said 'Wow'
I said "hi"
I said \"hi"
abc \
abc \\ wow
I said '\'hi\hey'
hey'
hey" |
Shaikh-Ubaid
force-pushed
the
asr_unescaped_strings
branch
from
May 6, 2023 10:34
30d0f8a
to
ad5a1db
Compare
Closed
certik
approved these changes
May 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1759.