Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync libasr with LFortran #1847

Merged
merged 2 commits into from
May 23, 2023
Merged

Sync libasr with LFortran #1847

merged 2 commits into from
May 23, 2023

Conversation

czgdp1807
Copy link
Collaborator

@czgdp1807 czgdp1807 commented May 22, 2023 •
edited
Loading

Corresponding LFortran PR - lfortran/lfortran#1681

Smit-create
Smit-create reviewed May 22, 2023
View reviewed changes
src/libasr/codegen/asr_to_c_cpp.h Outdated Show resolved Hide resolved
src/libasr/codegen/asr_to_c_cpp.h Outdated Show resolved Hide resolved
src/libasr/codegen/asr_to_c_cpp.h Outdated Show resolved Hide resolved
src/libasr/codegen/asr_to_c_cpp.h Outdated Show resolved Hide resolved
src/libasr/codegen/asr_to_c_cpp.h Outdated Show resolved Hide resolved
src/libasr/codegen/asr_to_c_cpp.h Outdated Show resolved Hide resolved
src/libasr/codegen/asr_to_c_cpp.h Outdated Show resolved Hide resolved
src/libasr/codegen/c_utils.h Outdated Show resolved Hide resolved
src/libasr/runtime/lfortran_intrinsics.c Outdated Show resolved Hide resolved
@czgdp1807 czgdp1807 force-pushed the libasr_sync_03 branch 2 times, most recently from 3e34d29 to 193e982 Compare May 22, 2023 10:46
@Thirumalai-Shaktivel
Copy link
Collaborator

Thirumalai-Shaktivel commented May 22, 2023 •
edited
Loading

@czgdp1807 Should I submit a separate Sync PR to LFortran for the IntrinisicFunction changes or you will submit the required changes through the "Sync libasr with LPython" PR?

@czgdp1807
Copy link
Collaborator Author

czgdp1807 commented May 22, 2023 •
edited
Loading

Let us complete the sync process first before making any updates elsewhere.

@czgdp1807 czgdp1807 force-pushed the libasr_sync_03 branch 2 times, most recently from 9a4a43b to cbd1dc6 Compare May 22, 2023 12:15
@czgdp1807
Copy link
Collaborator Author

I think Windows test fail due to changes related to unescape_string. @Thirumalai-Shaktivel Can you please check?

@Shaikh-Ubaid
Copy link
Collaborator

I think Windows test fail due to changes related to unescape_string

I think that should not happen. We are keeping strings unescaped in AST and ASR since #1762. I think if the escaping/unescaping of strings was an issue in windows, we would have come across it in the same PR #1762.

certik
certik approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the ASR changes and runtime lib changes and things at high level and it looks good, I don't see any roadblock.

@czgdp1807 czgdp1807 mentioned this pull request May 22, 2023
Merged
@czgdp1807 czgdp1807 marked this pull request as ready for review May 22, 2023 17:09
Smit-create
Smit-create approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@Smit-create Smit-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@czgdp1807 czgdp1807 force-pushed the libasr_sync_03 branch 2 times, most recently from e5f83a2 to eacb4f6 Compare May 22, 2023 17:52
Pranavchiku
Pranavchiku approved these changes May 22, 2023
View reviewed changes
Copy link

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the sync :)

Shaikh-Ubaid
Shaikh-Ubaid approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thank you so much for this! Also, please see lfortran/lfortran#1681 (comment).

@czgdp1807 czgdp1807 enabled auto-merge May 23, 2023 04:33
@czgdp1807 czgdp1807 merged commit 2aacbb6 into lcompilers:main May 23, 2023
@czgdp1807 czgdp1807 deleted the libasr_sync_03 branch May 23, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

@Thirumalai-Shaktivel Thirumalai-Shaktivel Thirumalai-Shaktivel approved these changes

@Smit-create Smit-create Smit-create approved these changes

@Shaikh-Ubaid Shaikh-Ubaid Shaikh-Ubaid approved these changes

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@czgdp1807 @Thirumalai-Shaktivel @Shaikh-Ubaid @certik @Smit-create @Pranavchiku