Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Default Resolver + GQL Dataloaders #64

Closed
wants to merge 29 commits into from

Conversation

fahimalizain
Copy link
Member

@fahimalizain fahimalizain commented Aug 12, 2022

There are two optimizations done here.

  • Default Resolver has been broken down into simpler resolvers and attached for all those fields that the default resolver previously served
  • Introduced Dataloaders implemented in the PR graphql-core #155

Fixes #53

@fahimalizain fahimalizain added the WIP Work In Progress label Aug 13, 2022
fahimalizain and others added 14 commits August 13, 2022 14:26
fix: Use get_list in doc-dataloader

feat: Basic Perms for new resolvers


Co-authored-by: Fahim Ali Zain <[email protected]>

Merge-request: ROMMAN-MR-126
Merged-by: Fahim Ali Zain <[email protected]>
* feat: Field Level Perms

* fix: keywords in field names
Co-authored-by: Fahim Ali Zain <[email protected]>

Merge-request: ROMMAN-MR-178
Merged-by: Fahim Ali Zain <[email protected]>
fix: remove redundant resolver check

Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-481-translations

feat: Translations Support


Co-authored-by: Fahim Ali Zain <[email protected]>

Merge-request: ROMMAN-MR-177
Merged-by: Fahim Ali Zain <[email protected]>
Co-authored-by: Abadulrehman <[email protected]>

Merge-request: ROMMAN-MR-196
Merged-by: Fahim Ali Zain <[email protected]>
@fahimalizain fahimalizain force-pushed the ROMMAN-T-289-kick-default-resolver branch from ede2360 to ea01ae7 Compare August 26, 2022 11:47
e-lobo and others added 8 commits September 8, 2022 13:22
…el Restricted Fields

fix: check for GraphQLNonNull

fix: use default_field_resolver from graphql

fix: refactored perm checks

fix: Raise Perm Error on GQLNonNull Permlevel Restricted Fields


Co-authored-by: Fahim Ali Zain <[email protected]>

Merge-request: ROMMAN-MR-214
Merged-by: Fahim Ali Zain <[email protected]>
* refactor: use graphql-sync-dataloader package

* refactor: update package graphql-sync-dataloader
tests: fix test_deleted_doc_resolution

Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-433-document-resolver-tests

Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-433-document-resolver-tests

tests: Update DocumentResolver Tests


Co-authored-by: Fahim Ali Zain <[email protected]>

Merge-request: ROMMAN-MR-368
Merged-by: Fahim Ali Zain <[email protected]>
@leambot leambot closed this Jan 14, 2023
@leambot leambot deleted the ROMMAN-T-289-kick-default-resolver branch January 14, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching fields of connected docs is slow
4 participants