add third party github login for future updates in vscode-leetcode #34

yihong0618 · 2019-12-16T05:50:29Z

Add third party github login for future updates in vscode-leetcode and somehow solve the recaptcha problem.

This pr add feature for vscode-leetcode third party auth.
somehow can solve the recaptcha problem for leetcode-vscode can't login

Users only need to connect github(or already connected) can use leetcode user -g can login leetcode in leetcode-cli and future for vscode-leetcode(other third parties also can add except google... I will add it if necessary)

how to connect github

find profile page (https://leetcode.com/profile/account/)
link your github id like below
Or user use github to login leetcode at the first will also work
use github account can login to leetcode

…d somehow solve the recaptcha problem

jdneo · 2019-12-16T06:22:21Z

Will take a look at the PR before the end of this week. Thank you @yihong0618

jdneo

Please correct me if I'm wrong.
If the user enables two-factor auth in GitHub, this method won't able to login, I'm I right?

README.md

lib/commands/user.js

yihong0618 · 2019-12-17T12:36:36Z

And I tonight I will add Linkedin login maybe, Facebook has a little problem, Google will not work
I think in vscode-leetcode just one third party login will be nice, user can just select their way to login.
And just to change singin method in vscode-leetcode will be easy.

jdneo · 2019-12-18T01:38:13Z

Hmm, actually I failed to login using my GitHub account. Does your GitHub account enable the two-factor auth?

yihong0618 · 2019-12-18T01:44:03Z

Hmm, actually I failed to login using my GitHub account. Does your GitHub account enable the two-factor auth?
Sorry, two-factor auth is not support for now
Mine is fine. I will test another account.

No my account not enable two-factor auth
Did you use your Github accout not your leetcode accout
Did you link your Github accout to leetcode in leetcode.
Can you try to linkedin accout either, because I only have one, sorry for that.

jdneo · 2019-12-18T01:50:05Z

Sure I'll try with LinkedIn later tonight...

yihong0618 · 2019-12-18T01:56:33Z

I sign up a new accout that use github accout at the first time.
If its a new accout you must verity your email in leetcode and email accout, maybe you miss that?

jdneo · 2019-12-18T02:05:04Z

It should be verified before. The account already connected.

Could you try enable the 2-factor auth for your GitHub account? You can find it in the Settings > Security

yihong0618 · 2019-12-18T02:07:53Z

It should be verified before. The account already connected.

Could you try enable the 2-factor auth for your GitHub account? You can find it in the Settings > Security

Trying.....
But I found no +86(China) for sms

yihong0618 · 2019-12-18T02:14:54Z

It should be verified before. The account already connected.

Could you try enable the 2-factor auth for your GitHub account? You can find it in the Settings > Security

And I think you can disconnect and connect another Github account for test.
Before that you should logout your github account in chrome because leetcode connect will read your session

jdneo · 2019-12-18T10:20:02Z

Tried another GitHub account without 2-factor auth, and login successfully.

So I think we can first hint to user that 2-factor auth is not supported yet. And spend some time to see if it is possible to enable it.

jdneo

Well Done!

jdneo · 2019-12-18T10:21:12Z

lib/plugins/leetcode.js

+      _request.get({url: leetcodeUrl}, function(e, resp, body) {
+        const redirectUri = resp.request.uri.href;
+        if (redirectUri !== 'https://leetcode.com/') {
+          return cb('GitHub login failed or GitHub did not link to leetcode');


leetcode -> LeetCode

jdneo · 2019-12-18T10:21:23Z

lib/plugins/leetcode.js

+  });
+  _request('https://www.linkedin.com', function(e, resp, body) {
+    if ( resp.statusCode !== 200) {
+      return cb('Get linkedin session failed');


linkedin -> LinkedIn

jdneo · 2019-12-18T10:21:35Z

lib/plugins/leetcode.js

+    }
+    const authenticityToken = body.match(/input name="loginCsrfParam" value="(.*)" /);
+    if (authenticityToken === null) {
+      return cb('Get Linkedin token failed');


jdneo · 2019-12-18T10:21:44Z

lib/plugins/leetcode.js

+      _request.get({url: leetcodeUrl}, function(e, resp, body) {
+        const redirectUri = resp.request.uri.href;
+        if (redirectUri !== 'https://leetcode.com/') {
+          return cb('Linkedin login failed or Linkedin did not link to leetcode');


LinkedIn

LeetCode

Sorry for that, I will correct them~
Thank you very much for your help ~

yihong0618 · 2019-12-18T10:39:18Z

Tried another GitHub account without 2-factor auth, and login successfully.

So I think we can first hint to user that 2-factor auth is not supported yet. And spend some time to see if it is possible to enable it.

OK, seems a little hard but I will try.
And facebook way I think it is not worth because I use m.facebook.com a hack way to login.
Although successful but cause the facebook security alert, so I deleted the method.

jdneo · 2019-12-18T10:55:21Z

Yes, no need to support facebook at this time. GitHub and LinkedIn are good enough!

jdneo · 2019-12-24T11:17:44Z

Thank you @yihong0618.

Would you like me to publish a new release for this change?

yihong0618 · 2019-12-24T11:39:04Z

Yes.
And I found a way to solve the two-factor code. But it will use another package.
And I am not sure if it could be work in vscode-leetcode.
So I will have another pr, can you help me with that to check if the two-factor can be used in vscode-leetcode.
Thank you very much. The new pr will send in 10-20 minutes.
Thanks again.

jdneo · 2019-12-25T03:04:47Z

@yihong0618 Sure! Will the PR you mentioned be raised in this repo?

yihong0618 · 2019-12-25T03:12:57Z

@jdneo
Yes, see this #35
Thank you very much!

add third party github login for future updates in vscode-leetcode an…

04b4dc1

…d somehow solve the recaptcha problem

yihong0618 mentioned this pull request Dec 16, 2019

Failed to log in with a leetcode.com account LeetCode-OpenSource/vscode-leetcode#478

Open

zhencode1 approved these changes Dec 16, 2019

View reviewed changes

jdneo reviewed Dec 17, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

lib/commands/user.js Outdated Show resolved Hide resolved

add third party--Linkedin and fix typo by review.

51ca691

fix typo

57e39f8

jdneo reviewed Dec 18, 2019

View reviewed changes

yihong0618 added 2 commits December 18, 2019 19:08

fix typo

3663a98

fix another typo

a3c2dc6

jdneo approved these changes Dec 24, 2019

View reviewed changes

jdneo merged commit 1f26fbd into leetcode-tools:master Dec 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add third party github login for future updates in vscode-leetcode #34

add third party github login for future updates in vscode-leetcode #34

yihong0618 commented Dec 16, 2019 •

edited

Loading

jdneo commented Dec 16, 2019

jdneo left a comment

yihong0618 commented Dec 17, 2019 •

edited

Loading

jdneo commented Dec 18, 2019

yihong0618 commented Dec 18, 2019 •

edited

Loading

jdneo commented Dec 18, 2019

yihong0618 commented Dec 18, 2019

jdneo commented Dec 18, 2019

yihong0618 commented Dec 18, 2019

yihong0618 commented Dec 18, 2019

jdneo commented Dec 18, 2019

jdneo left a comment

jdneo Dec 18, 2019

jdneo Dec 18, 2019

jdneo Dec 18, 2019

jdneo Dec 18, 2019

yihong0618 Dec 18, 2019

yihong0618 commented Dec 18, 2019

jdneo commented Dec 18, 2019

jdneo commented Dec 24, 2019

yihong0618 commented Dec 24, 2019

jdneo commented Dec 25, 2019

yihong0618 commented Dec 25, 2019

add third party github login for future updates in vscode-leetcode #34

add third party github login for future updates in vscode-leetcode #34

Conversation

yihong0618 commented Dec 16, 2019 • edited Loading

jdneo commented Dec 16, 2019

jdneo left a comment

Choose a reason for hiding this comment

yihong0618 commented Dec 17, 2019 • edited Loading

jdneo commented Dec 18, 2019

yihong0618 commented Dec 18, 2019 • edited Loading

jdneo commented Dec 18, 2019

yihong0618 commented Dec 18, 2019

jdneo commented Dec 18, 2019

yihong0618 commented Dec 18, 2019

yihong0618 commented Dec 18, 2019

jdneo commented Dec 18, 2019

jdneo left a comment

Choose a reason for hiding this comment

jdneo Dec 18, 2019

Choose a reason for hiding this comment

jdneo Dec 18, 2019

Choose a reason for hiding this comment

jdneo Dec 18, 2019

Choose a reason for hiding this comment

jdneo Dec 18, 2019

Choose a reason for hiding this comment

yihong0618 Dec 18, 2019

Choose a reason for hiding this comment

yihong0618 commented Dec 18, 2019

jdneo commented Dec 18, 2019

jdneo commented Dec 24, 2019

yihong0618 commented Dec 24, 2019

jdneo commented Dec 25, 2019

yihong0618 commented Dec 25, 2019

yihong0618 commented Dec 16, 2019 •

edited

Loading

yihong0618 commented Dec 17, 2019 •

edited

Loading

yihong0618 commented Dec 18, 2019 •

edited

Loading