solve GitHub login two-factor auth problem and add new node package p… #35

yihong0618 · 2019-12-24T11:58:25Z

…rompt-sync
Solve two-factor auth problem and format some code.

Please help me check if this way can use in vscode-leetcode or not, because I did not find a way, thank you very much.

…rompt-sync

jdneo

I just tried with my GitHub account and it works!!

lib/plugins/leetcode.js

yihong0618 · 2019-12-25T14:17:35Z

@jdneo
Hi~ I fixed the code by your so kind review, thank you for your help.
And I have not solved the two-factor in vscode-leetcode maybe the sync-prompt way doesn't support I don't konw~, so this pr only support GitHub and LinkedIn way without two-factor.
By the way I found a way to add "+86" phone number with two-factor in GitHub because of this pr~
see this, kind of interesting, share with you~
Thank you for your patience again.

jdneo · 2019-12-26T02:31:20Z

@yihong0618 could you please share more information about the errors you observed from the vs code extension side?

Since the third-party login can unblock a lot of users, how about we release a new CLI without the two-factor auth support at first. Then we revisit this issue after that?

yihong0618 · 2019-12-26T02:43:55Z

@jdneo
OK, the formation about the errors will send here maybe tonight.
You are right, maybe you can release the last pr and this, the vscode-leetcode side for two-factor later will be best.
And I vscode-leetcode pr has been raised~

yihong0618 · 2019-12-27T01:47:03Z

@jdneo
I try to add two-factor in vsocde-leetcode but when prompt the two input the errors are as below

login: pass: Please enter your two-factor code:
fs.js:114
throw err;
^

Error: EOF: end of file, read
at Object.readSync (fs.js:498:3)
at prompt (c:\Users\hongyi\Documents\projects\new-vscode-leetcode\vscode-leetcode\node_modules\prompt-sync\index.js:85:17)
at Request._callback (c:\Users\hongyi\Documents\projects\new-vscode-leetcode\vscode-leetcode\node_modules\vsc-leetcode-cli\lib\plugins\leetcode.js:623:55)
at Request.self.callback (c:\Users\hongyi\Documents\projects\new-vscode-leetcode\vscode-leetcode\node_modules\request\request.js:185:22)
at Request.emit (events.js:198:13)
at Request. (c:\Users\hongyi\Documents\projects\new-vscode-leetcode\vscode-leetcode\node_modules\request\request.js:1161:10)
at Request.emit (events.js:198:13)
at IncomingMessage. (c:\Users\hongyi\Documents\projects\new-vscode-leetcode\vscode-leetcode\node_modules\request\request.js:1083:12)
at Object.onceWrapper (events.js:286:20)
at IncomingMessage.emit (events.js:203:15)

And no problem for no two-factor

I think vscode-leetcode only support GitHub login without two-factor will be good for now.
And this pr has no side effect in vscode-leetcode side.
So I think the pr can support two-factor in leetcode-cli and we can find other way to support vscode-leetcodet in the future.
Thank you~

jdneo · 2019-12-27T02:08:07Z

I see. I'll release the CLI first to unblock the vscode-leetcode's PR. Just leave this PR here for now until we release the VS Code LeetCode.

yihong0618 · 2019-12-27T02:18:47Z

@jdneo
Thank you very much.
And can you help me to solve the ci problem, because every time I failed and I don't find the infomation why.

yihong0618 · 2019-12-27T13:47:50Z

@jdneo
Just support GitHub and LinkedIn login for leetcode-cn.com

lib/plugins/leetcode.js

jdneo · 2019-12-30T02:23:56Z

lib/plugins/leetcode.js

+      return cb(`${party} login failed or ${party} did not connect to LeetCode`);
+    }
+    let cookieData = {};
+    if (leetcodeUrl.includes('cn')) {


cn -> leetcode-cn.com to avoid mismatch

lib/plugins/leetcode.js

jdneo · 2019-12-30T06:05:38Z

lib/plugins/leetcode.js

+          requestLeetcodeAndSave(_request, leetcodeUrl, user, cb, config.sys.login_methods.GitHub);
+        });
+      } else {
+        requestLeetcodeAndSave(_request, leetcodeUrl, user, cb, config.sys.login_methods.GitHub);


Can the calling of requestLeetcodeAndSave in line 648 and line 651 merged into one call -- move it out of the if-else block?

Sorry, these two are with different session(_request), the first one is two-factor, the second one is normal. Both need.

I see. How about

if (resp.request.uri.href !== urls.github_tf_redirect) { return requestLeetcodeAndSave(_request, leetcodeUrl, user, cb, config.sys.login_methods.GitHub); } cb('Your GitHub are using two-factor authentication'); // read two-factor code must be sync. const twoFactorcode = require('prompt-sync')()('Please enter your two-factor code: '); const authenticityTokenTwoFactor = body.match(/name="authenticity_token" value="(.*?)"/); if (authenticityTokenTwoFactor === null) { return cb('Get GitHub two-factor token failed'); } const optionsTwoFactor = { url: urls.github_tf_session_request, method: 'POST', headers: { 'Content-Type': 'application/x-www-form-urlencoded', }, followAllRedirects: true, form: { 'otp': twoFactorcode, 'authenticity_token': authenticityTokenTwoFactor[1], 'utf8': encodeURIComponent('✓'), }, }; _request(optionsTwoFactor, function(e, resp, body) { if (resp.request.uri.href === urls.github_tf_session_request) { return cb('Invalid two-factor code please check'); } requestLeetcodeAndSave(_request, leetcodeUrl, user, cb, config.sys.login_methods.GitHub); });

which can save some indentions.

Yes! Very clean code. Thank you.

lib/plugins/leetcode.js

…e if cn test) to make it more clear, also fixed a tiny bug before

jdneo · 2019-12-30T08:17:12Z

lib/config.js

+      plugin:                    'https://raw.githubusercontent.com/leetcode-tools/leetcode-cli-plugins/master/plugins/$name.js'
+    },
+    // login methods enum
+    login_methods: {


This field can also be removed

… review

jdneo

Well done!

E011011101001 · 2022-03-16T11:40:06Z

Did this PR make cookie login unusable?

In leetcode.js, function parseCookie (Line 541) is changed and cb becomes the third parameter. However when it is called at Line 577, cb remains to be the second argument. This problem remains in the latest commit today

When I was running this tool trying to login by cookie, I got a error says TypeError: cb is not a function. I think this bug was imported here.

yihong0618 added 2 commits December 24, 2019 19:54

solve GitHub login two-factor auth problem and add new node package p…

5ef6c1b

…rompt-sync

delete unused function and fix typo

f7a6b53

yihong0618 mentioned this pull request Dec 25, 2019

add third party github login for future updates in vscode-leetcode #34

Merged

jdneo reviewed Dec 25, 2019

View reviewed changes

format the code by review

53b3446

yihong0618 added 2 commits December 27, 2019 10:20

Merge branch 'master' into master

294dbe2

support GitHub and LinkedIn login for leetcode-cn.com

94ac8a4

lint

3122ac7

yihong0618 mentioned this pull request Dec 29, 2019

add thrid party login -- GitHub and LinkedIn LeetCode-OpenSource/vscode-leetcode#496

Merged

jdneo reviewed Dec 30, 2019

View reviewed changes

lib/plugins/leetcode.js Outdated Show resolved Hide resolved

format naming by review and refactor the parse cookie function(includ…

e3680fe

…e if cn test) to make it more clear, also fixed a tiny bug before

jdneo reviewed Dec 30, 2019

View reviewed changes

yihong0618 and others added 2 commits December 30, 2019 16:39

delete unused config and make the github login function more clear by…

1cdf7f8

… review

Merge branch 'master' into master

8c1159e

jdneo approved these changes Dec 30, 2019

View reviewed changes

jdneo merged commit a11e137 into leetcode-tools:master Dec 30, 2019

E011011101001 mentioned this pull request Mar 16, 2022

fix: couldn't login to leetcode main site by cookie #62

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

solve GitHub login two-factor auth problem and add new node package p… #35

solve GitHub login two-factor auth problem and add new node package p… #35

yihong0618 commented Dec 24, 2019

jdneo left a comment

yihong0618 commented Dec 25, 2019 •

edited

Loading

jdneo commented Dec 26, 2019

yihong0618 commented Dec 26, 2019 •

edited

Loading

yihong0618 commented Dec 27, 2019 •

edited

Loading

jdneo commented Dec 27, 2019

yihong0618 commented Dec 27, 2019 •

edited

Loading

yihong0618 commented Dec 27, 2019

jdneo Dec 30, 2019

jdneo Dec 30, 2019

yihong0618 Dec 30, 2019 •

edited

Loading

jdneo Dec 30, 2019

yihong0618 Dec 30, 2019

jdneo Dec 30, 2019

jdneo left a comment

E011011101001 commented Mar 16, 2022

solve GitHub login two-factor auth problem and add new node package p… #35

solve GitHub login two-factor auth problem and add new node package p… #35

Conversation

yihong0618 commented Dec 24, 2019

jdneo left a comment

Choose a reason for hiding this comment

yihong0618 commented Dec 25, 2019 • edited Loading

jdneo commented Dec 26, 2019

yihong0618 commented Dec 26, 2019 • edited Loading

yihong0618 commented Dec 27, 2019 • edited Loading

jdneo commented Dec 27, 2019

yihong0618 commented Dec 27, 2019 • edited Loading

yihong0618 commented Dec 27, 2019

jdneo Dec 30, 2019

Choose a reason for hiding this comment

jdneo Dec 30, 2019

Choose a reason for hiding this comment

yihong0618 Dec 30, 2019 • edited Loading

Choose a reason for hiding this comment

jdneo Dec 30, 2019

Choose a reason for hiding this comment

yihong0618 Dec 30, 2019

Choose a reason for hiding this comment

jdneo Dec 30, 2019

Choose a reason for hiding this comment

jdneo left a comment

Choose a reason for hiding this comment

E011011101001 commented Mar 16, 2022

yihong0618 commented Dec 25, 2019 •

edited

Loading

yihong0618 commented Dec 26, 2019 •

edited

Loading

yihong0618 commented Dec 27, 2019 •

edited

Loading

yihong0618 commented Dec 27, 2019 •

edited

Loading

yihong0618 Dec 30, 2019 •

edited

Loading