chore: Explicitly add defulat providers to builder config #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ign assumptions that enforce strict versioning and assume that inferred default provider modules match the builder version https://github.com/open-telemetry/opentelemetry-collector/blob/main/cmd/builder/internal/builder/config.go#L219-L231
|
Explicitly defining based on this opened issue |
adrielp
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a no-op change but should make future updates easier.
OCB made assumptions that implied default providers matched the builder version https://github.com/open-telemetry/opentelemetry-collector/blob/main/cmd/builder/internal/builder/config.go#L219-L231
This is a bad assumption as uncovered by the 1.15.0/0.109.0 release. A couple of the default providers moved to stable while others are not and the builder is still not stable.
There has been conversations to resolve this but there is enforced strict versioning checks that make this more challenging.
The provided advice now is to explicitly set default providers in the builder config. https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.109.0
This is a chore because currently the implied default providers match the builder version thus the latest release is good. Putting them here explicitly will ensure we update these providers as others move to stable.