-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/builder] Updating OCB to v0.109.0 broke implied providers #11152
Labels
bug
Something isn't working
Comments
Hi @jburns24, Thanks for a very detailed report, I've also updated the release notes to point to this problem https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.109.0. Also this was discussed in #11129. Unfortunately our first fix does not work because of the |
adrielp
pushed a commit
to liatrio/liatrio-otel-collector
that referenced
this issue
Sep 12, 2024
Explicitly add providers to builder config due to upstream design assumptions that enforce strict versioning and assume that inferred default provider modules match the builder version * https://github.com/open-telemetry/opentelemetry-collector/blob/main/cmd/builder/internal/builder/config.go#L219-L231 * open-telemetry/opentelemetry-collector#11152
mx-psi
added a commit
that referenced
this issue
Sep 13, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Disable strict version check. The `--skip-strict-version-check` is kept but is now a no-op. This fixes #11152. <!-- Issue number if applicable --> #### Link to tracking issue Fixes #11152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Updating our collector components including cmd/builder to v0.109.0 caused build failures when resolving
envprovider
and runtime errors for thefileprovider
.After updating to v0.109.0 building our collector errored out with the following.
I noticed in the core collector and the contrib collector your OCB config files specified
Adding this to our builder config file resolved the build error.
Updating to 0.109.0 also caused our collector to fail with the following runtime error when trying to pass in a config file
Adding the following to the list of
providers
in the builder config file resolved this runtime error.Steps to reproduce
providers
section ofconfig/manifest.yaml
make build
-> this will give theenvprovider
errorTo reproduce the runtime error you would need to go through the Get Started guide and then run
make run
What did you expect to see?
Building the collector and running the collector without explicitly setting these providers in the OCB builder configuration worked. This worked for us when using v0.108.0 (which you can see if you checkout v0.67.0 of the liatrio-otel-collector)
What version did you use?
v0.109.0
What config did you use?
Environment
OS: macOS 14.5 (23F79)
Compiler: go 1.23
The text was updated successfully, but these errors were encountered: