This commit introduces a new feature that checks if participants' inc… #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome over the past four weeks meets or exceeds their stated weekly income goals. If the condition is met and the participant hasn't been notified recently, a notification is sent. Changes include: - Updated SQL schema to add 'weekly_income_goal' to the 'participants' table and create an 'income_notifications' table for tracking sent notifications. - Added methods in the model: - to perform the check against the set income goal. - to calculate the total received income within a specific date range. - to determine if a notification was recently sent. - to handle the sending of notifications and record them in the database. - Implemented tests in a new file : - Test for the scenario where the income goal is met and a notification is sent. - Test for the scenario where the income goal is not met. - Test to ensure no notification is sent if one was sent recently. These additions enhance user engagement by actively notifying users about their income status in relation to their goals, improving the platform's support for financial tracking and user motivation.
|
There are so many mistakes in this patch that I'm not sure it's worth writing a detailed review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include: - Updated SQL schema to add 'weekly_income_goal' to the 'participants' table and create an 'income_notifications' table for tracking sent notifications. - Added methods in the model: