-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to sbt 0.13.13-RC3 #130
Conversation
Something's wrong. The Travis build took too little and produced too little output. |
Migrate from the Build trait, the fishbone operators and tuple enrichment syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
} | ||
|
||
def project(id: String, base: File, settings: Seq[Def.Setting[_]] = Nil) = | ||
Project(id, base, settings = settings) disablePlugins(BintrayPlugin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add a common prefix to all of these autogenerated projects like test
. Makes going through the output of projects
a bit easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you eliminate whitespace changes you'll see that that's def isn't new/my doing: https://github.com/typesafehub/migration-manager/pull/130/files?w=1
But sure, sounds much better than the status quo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That was what I meant. Improving the status quo. :)
Travis failed with |
Green lights! |
Migrate from the Build trait, the fishbone operators and tuple enrichment syntax.
To avoid bike shedding arguments holding up this PR I've gone for a (mostly) minimal-diff approach.