Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sbt 0.13.13-RC3 #130

Merged
merged 3 commits into from
Oct 19, 2016
Merged

Upgrade to sbt 0.13.13-RC3 #130

merged 3 commits into from
Oct 19, 2016

Conversation

dwijnand
Copy link
Collaborator

Migrate from the Build trait, the fishbone operators and tuple enrichment syntax.

To avoid bike shedding arguments holding up this PR I've gone for a (mostly) minimal-diff approach.

@dwijnand
Copy link
Collaborator Author

dwijnand commented Oct 18, 2016

Something's wrong. The Travis build took too little and produced too little output.

Migrate from the Build trait, the fishbone operators and tuple enrichment syntax.
Copy link
Contributor

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

}

def project(id: String, base: File, settings: Seq[Def.Setting[_]] = Nil) =
Project(id, base, settings = settings) disablePlugins(BintrayPlugin)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a common prefix to all of these autogenerated projects like test. Makes going through the output of projects a bit easier.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you eliminate whitespace changes you'll see that that's def isn't new/my doing: https://github.com/typesafehub/migration-manager/pull/130/files?w=1

But sure, sounds much better than the status quo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That was what I meant. Improving the status quo. :)

@SethTisue
Copy link
Collaborator

Travis failed with java.util.concurrent.ExecutionException: java.lang.OutOfMemoryError: GC overhead limit exceeded, maybe just needs more heap?

@dwijnand
Copy link
Collaborator Author

Green lights!

@2m 2m merged commit b46bd0a into lightbend-labs:master Oct 19, 2016
@dwijnand dwijnand deleted the build branch October 19, 2016 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants