Refactor functional tests to only one project and a command. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR validation failed because of #74 |
* instead of a project per tests-case there is now one project, which has scalaSource setting set to a corresponding test-case source dir before test is being run.
2m
force-pushed
the
wip-function-tests-command
branch
from
2640e68
to
38162ed
Compare
|
@2m I believe this still needs work on your side, so it shouldn't be reviewed or merged just yet, should it? |
|
Correct. Commit message indicates that it should not be merged just yet. It is fully functional, but because of lost parallelism, it is way slower than original functional tests implementation. |
|
Situation has been improved with the latest sbt support for project generation from auto plugins and #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a project per tests-case there is now one project, which has
scalaSourcesetting set to a corresponding test-case source dir before a test is being run.Also fixes #82 (sbt build now fails on a functional test fail)