Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix http double headers #160

Closed
wants to merge 2 commits into from
Closed

fix http double headers #160

wants to merge 2 commits into from

Commits on Sep 7, 2018

  1. fix double headers when reusing the *http.Request 

    because of opentracing/opentracing-go#159
the headers in a reused *http.Request are appended instead of set
which results in headers like this after injecting the current span
context:
```
ot-tracer-spanid: 911775291efa49de,46fbd688b66dc96d
ot-tracer-traceid: 24080003fd414b3d,24080003fd414b3d
ot-tracer-sampled: true,true
```

With these double headers at least the java client is unable to
extract the current span context.
    @vetinari
    vetinari committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    b5282c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:lightstep/lightstep-tracer-go int… 

    …o http-double-headers
    @vetinari
    vetinari committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    a8cda3a View commit details
    Browse the repository at this point in the history